Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annepro2: match default configurator config with firmware default keymap #1106

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

bwisn
Copy link
Contributor

@bwisn bwisn commented Mar 24, 2022

annepro2: match default configurator config with firmware default keymap

Description

Needs qmk/qmk_firmware#16724 first.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K, this is gonna take a while to work out. Something about the Anne Pro's LED code makes it so JSON keymaps can't be compiled.

Ψ Compiling keymap with make -s --jobs=1 -r -R -f builddefs/build_keyboard.mk KEYBOARD=annepro2/c15 KEYMAP=layout_60_ansi_mine KEYBOARD_FILESAFE=annepro2_c15 TARGET=annepro2_c15_layout_60_ansi_mine KEYBOARD_OUTPUT=.build/obj_annepro2_c15 KEYMAP_OUTPUT=.build/obj_annepro2_c15_layout_60_ansi_mine MAIN_KEYMAP_PATH_1=.build/obj_annepro2_c15_layout_60_ansi_mine MAIN_KEYMAP_PATH_2=.build/obj_annepro2_c15_layout_60_ansi_mine MAIN_KEYMAP_PATH_3=.build/obj_annepro2_c15_layout_60_ansi_mine MAIN_KEYMAP_PATH_4=.build/obj_annepro2_c15_layout_60_ansi_mine MAIN_KEYMAP_PATH_5=.build/obj_annepro2_c15_layout_60_ansi_mine KEYMAP_C=.build/obj_annepro2_c15_layout_60_ansi_mine/src/keymap.c KEYMAP_PATH=.build/obj_annepro2_c15_layout_60_ansi_mine/src VERBOSE=false COLOR=true SILENT=false QMK_BIN="qmk"


arm-none-eabi-gcc (GNU Tools for ARM Embedded Processors 6-2017-q2-update) 6.3.1 20170620 (release) bedded-6-branch revision 249437]
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Generating: .build/obj_annepro2_c15/src/info_config.h                                               �
Generating: .build/obj_annepro2_c15/src/default_keyboard.h                                          �
Generating: .build/obj_annepro2_c15/src/layouts.h                                                   �
Compiling: keyboards/annepro2/matrix.c                                                              �
Compiling: keyboards/annepro2/annepro2_ble.c                                                        �
Compiling: keyboards/annepro2/ap2_led.c                                                             �
Compiling: keyboards/annepro2/protocol.c                                                            �
Compiling: keyboards/annepro2/rgb_driver.c                                                          �
Compiling: keyboards/annepro2/config_led.c                                                          �
Compiling: keyboards/annepro2/annepro2.c                                                           keyboards/annepro2/annepro2.c: In function 'process_record_kb':
keyboards/annepro2/annepro2.c:235:7: error: implicit declaration of function 'rgb_matrix_increase_hue' plicit-function-declaration]
       rgb_matrix_increase_hue();
       ^~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:238:7: error: implicit declaration of function 'rgb_matrix_decrease_hue' plicit-function-declaration]
       rgb_matrix_decrease_hue();
       ^~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:241:7: error: implicit declaration of function 'rgb_matrix_increase_val' plicit-function-declaration]
       rgb_matrix_increase_val();
       ^~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:249:7: error: implicit declaration of function 'rgb_matrix_increase_sat' plicit-function-declaration]
       rgb_matrix_increase_sat();
       ^~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:252:7: error: implicit declaration of function 'rgb_matrix_decrease_sat' plicit-function-declaration]
       rgb_matrix_decrease_sat();
       ^~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:255:7: error: implicit declaration of function 'rgb_matrix_decrease_val' plicit-function-declaration]
       rgb_matrix_decrease_val();
       ^~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:263:7: error: implicit declaration of function 'rgb_matrix_increase_speed' plicit-function-declaration]
       rgb_matrix_increase_speed();
       ^~~~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:266:7: error: implicit declaration of function 'rgb_matrix_decrease_speed' plicit-function-declaration]
       rgb_matrix_decrease_speed();
       ^~~~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:271:8: error: implicit declaration of function 'rgb_matrix_disable' plicit-function-declaration]
        rgb_matrix_disable();
        ^~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:275:8: error: implicit declaration of function 'rgb_matrix_enable' plicit-function-declaration]
        rgb_matrix_enable();
        ^~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:286:7: error: implicit declaration of function 'rgb_matrix_step_reverse' plicit-function-declaration]
       rgb_matrix_step_reverse();
       ^~~~~~~~~~~~~~~~~~~~~~~
keyboards/annepro2/annepro2.c:289:7: error: implicit declaration of function 'rgb_matrix_step' plicit-function-declaration]
       rgb_matrix_step();
       ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
 �
 | 
 | 
 | 
make: *** ine/keyboards/annepro2/annepro2.o] Error 1

I don't get this error if I compile from a keymap.c. 😕 🙁

@noroadsleft
Copy link
Member

Bugfix PR posted: qmk/qmk_firmware#16864

@noroadsleft
Copy link
Member

Bugfix was merged; everything's good now.

@noroadsleft noroadsleft merged commit fe416e0 into qmk:master Apr 17, 2022
@noroadsleft
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants