Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some English translations #14

Closed
wants to merge 1 commit into from
Closed

Conversation

nfoert
Copy link

@nfoert nfoert commented Oct 12, 2023

Hello! I noticed some of the English translations could be adjusted a little bit. Thanks for creating this plugin!

Note: I didn't test anything, just adjusted the localization strings.

@qing3962
Copy link
Owner

Thanks for your contributions,I will review your pull-request later.

@qing3962
Copy link
Owner

I accept your adjustment, but the location you modified is incorrect. You should modify the file "en.json" in "./langs" subdirectory instead of main.js. It's okay, I'll apply your adjustments to the en.json file.

@nfoert
Copy link
Author

nfoert commented Oct 16, 2023

Oh that's my mistake. I didn't see that part of the README. I appreciate the fix.

@qing3962
Copy link
Owner

qing3962 commented Oct 18, 2023

Hi nfoert,
I had modifed the English translations based on your adjustment, and had released version 1.1.20, please update.
thank you for your suggestion.

@qing3962 qing3962 closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants