Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable android test #689

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Re-enable android test #689

merged 1 commit into from
Feb 11, 2021

Conversation

bet4it
Copy link
Contributor

@bet4it bet4it commented Feb 11, 2021 •
edited
Loading

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

@xwings
Copy link
Member

xwings commented Feb 11, 2021

ah, our bad

thanks for the PR

@xwings xwings closed this Feb 11, 2021
@xwings xwings reopened this Feb 11, 2021
@xwings xwings merged commit 2522164 into qilingframework:dev Feb 11, 2021
xwings added a commit that referenced this pull request Feb 11, 2021
@xwings
Improved PR #689, Android syscall and test fix
1fcf666
@bet4it bet4it deleted the android branch February 12, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bet4it @xwings