POC for rocksdb memory usage metrics #3604
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to payload memory issues discussed in #3501 and tackled in #3557 and #3565
This PR is a PoC for exposing
get_memory_usage_stats
fromrust-rocksdb
for tracking memory usage inrocksdb
.This PR adds segment level stats to
/telemetry
and aggregated stats to/metrics
.As far as I can tell,
rust-rocksdb
does not make stats available for column families, only for databases.However, on my local test bench I saw one trend which correlated with the extreme RAM usage in our production environment,
mem_table_readers_total
, which seems to grow linearly wrt the number of vectors with payloads.I built this to scratch an itch and try and solve the memory problems plaguing us - but am also interested in getting a concept ACK on this, as I'm sure the code could be improved.
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: