Backports for v4_5_x part 2 #18452

sledgehammer999 · 2023-01-24T23:30:54Z

These will be merged (and rebased) after #18271.

Here is the list of the backported PRs for quick reference:
PR #18086
PR #18104
PR #18110
PR #18154
PR #18199
PR #18200
PR #18218
PR #18227
PR #18236
PR #18240
PR #18279
PR #18326
PR #18285
PR #18434
PR #18432
PR #18456
PR #18466

sledgehammer999 · 2023-01-24T23:52:24Z

After this I want to make the next release.

@glassez was not backporting #18227 #18218 deliberate?

Also how about #18110?

glassez · 2023-01-25T06:14:37Z

@glassez was not backporting #18227 #18218 deliberate?

They didn't look like bugfixes. However, I don't mind them, since they don't affect anything around.

Also how about #18110?

For me it fixes a "visual" bug. So if you want to backport it I don't mind.

xavier2k6 · 2023-01-25T11:00:18Z

After this I want to make the next release.

Please take my #18339 (comment) in to consideration/review.

glassez · 2023-01-25T11:30:15Z

Please take my #18339 (comment) in to consideration/review.

If you're hinting that @sledgehammer999 should have upgraded to MSVC 2022, then I'm in favor.
@sledgehammer999, it would also be nice to check the build for the ability to produce a valid stack trace. For example, you can inject some bug that obviously leads to a crash (division by zero, or something else), and check how it behaves, and only then rebuild it without that bug for release.

xavier2k6 · 2023-01-25T12:06:13Z

If you're hinting that @sledgehammer999 should have upgraded to MSVC 2022, then I'm in favor.

Yes

it would also be nice to check the build for the ability to produce a valid stack trace. For example, you can inject some bug that obviously leads to a crash (division by zero, or something else), and check how it behaves, and only then rebuild it without that bug for release.

Windows 10 21H2+ & Windows 11 seems to be the big issue currently.

It's easily reproducible via Qt 6 with the "when trying to paste using an empty clipboard" scenario from #18317 which is now fixed from upstream in upcoming Qt 6.4.3 ETA: 28.02.2023

(Have observed no issues either with Qt 6.4.2)

If you don't have a Windows 11 system available to you, I will test the release binaries for you if you want.
Have a system with Windows 11 22H2 Build 22621.

BTW (UPDATED tools are also available):
nasm 2.16.01
Ninja 1.11.1
NSIS 3.08

sledgehammer999 · 2023-01-25T15:52:07Z

The Qt6 builds are using msvc2022 starting from v4.4.3.
I can reproduce the issue @xavier2k6 is mentioning but inserting a deliberate crash. Running the app from inside WinDbg I can get a meaningful stacktrace. This at least denotes that the *.pdb file isn't corrupted.
I doubt that this has something to do with the SDK version used. My hunch is that this is a misconfiguration of Boost.Stacktrace. I am doing tests now to see if I can fix it.
Reminder: Our stacktrace functionality changed backends in v4.5.0.

sledgehammer999 · 2023-01-25T16:01:20Z

@xavier2k6 do you do the builds yourself? Are you able to test with builds fully statically linked?

sledgehammer999 · 2023-01-25T18:49:30Z

Let's continue in #18456

Pentaphon · 2023-01-26T00:40:02Z

For me it fixes a "visual" bug. So if you want to backport it I don't mind.

Please do.

I also fixed it on Transifex.

Leftover from the system tray code refactoring.

PR qbittorrent#18154.

It has been moved to its own repo: https://github.com/qbittorrent/docker-qbittorrent-nox PR qbittorrent#18199.

Upload an AppImage artifact on CI builds. This AppImage is a simplified version of the official one. It is meant to help with debugging PRs that fix issues.

PR qbittorrent#18236.

PR qbittorrent#18240.

PR qbittorrent#18279.

PR qbittorrent#18326. Fixes qbittorrent#18325. Fixes qbittorrent#14033.

Don't want torrent search history to pop up next time you try to search for torrents, right? There are people who would search for 18+ content and what they searched would load up next time they are about to search. PR qbittorrent#18285.

PR qbittorrent#18434.

Related to PR qbittorrent#17978

PR qbittorrent#18227. Closes qbittorrent#16052.

PR qbittorrent#18218.

PR qbittorrent#18110.

sledgehammer999 · 2023-01-27T16:08:00Z

I backported: #18110 #18218 #18227 #18456

This the webui part of PR qbittorrent#18110

Affects transfer list and status filters Related to PR qbittorrent#18110

sledgehammer999 · 2023-01-28T15:06:49Z

Also backported PR #18466.
@glassez can you approve? (I won't merge immediately)

Pentaphon · 2023-02-10T10:02:20Z

Is 4.5.x going to be a short run of fixes in favor of 4.6.0? I thought 4.5.1 was due a month ago?

xavier2k6 · 2023-02-10T12:15:17Z

Is 4.5.x going to be a short run of fixes in favor of 4.6.0?

More than likely yes for the near future anyway, qBittorrent 4.5.2 will possibly include a Qt upstream fix for a certain type of crash soon after Qt releases it at end of February & it's confirmed by team members that it indeed fixes reported upstream issue.

I thought 4.5.1 was due a month ago?

We don't give any guaranteed deadlines & it's best not to take anyone's comments etc. out of context as a fact.

xavier2k6 · 2023-02-15T09:08:48Z

@xavier2k6 do you do the builds yourself?

I've build previously mostly following the wiki guide, but lately for testing purposes etc - I use GHA CI provided builds.

Are you able to test with builds fully statically linked?

Yes, following the wiki guide etc.

sledgehammer999 added this to the 4.5.1 milestone Jan 24, 2023

sledgehammer999 requested a review from glassez January 24, 2023 23:30

glassez added the Backport label Jan 25, 2023

This comment was marked as off-topic.

Sign in to view

glassez closed this Jan 25, 2023

glassez reopened this Jan 25, 2023

sledgehammer999 mentioned this pull request Jan 25, 2023

Fix PDB loading for valid stacktraces #18456

Merged

sledgehammer999 and others added 11 commits January 27, 2023 18:01

Remove trailing newline from translation file

6cf1351

I also fixed it on Transifex.

Remove dead code

2123c1c

Leftover from the system tray code refactoring.

WebUI: Make rename file dialog resizable

eb97e64

PR qbittorrent#18154.

Remove docker information

40d94fd

It has been moved to its own repo: https://github.com/qbittorrent/docker-qbittorrent-nox PR qbittorrent#18199.

[CI Ubuntu] Strip installed components

2517e68

[CI Ubuntu] Build AppImage

aa43fc8

Upload an AppImage artifact on CI builds. This AppImage is a simplified version of the official one. It is meant to help with debugging PRs that fix issues.

Prevent incorrect line breaking

5e29960

PR qbittorrent#18236.

NSIS: Update Swedish translation

dcbff74

PR qbittorrent#18240.

GHA CI: Bump Boost version to 1.81.0 on Windows/macOS

5dc1c10

PR qbittorrent#18279.

WebUI: Improve hotkeys

eb98a04

PR qbittorrent#18326. Fixes qbittorrent#18325. Fixes qbittorrent#14033.

Remove suggestions while searching for torrents

961e05e

Don't want torrent search history to pop up next time you try to search for torrents, right? There are people who would search for 18+ content and what they searched would load up next time they are about to search. PR qbittorrent#18285.

valiukasd and others added 8 commits January 27, 2023 18:01

NSIS: Update Lithuanian translation

d20633f

PR qbittorrent#18434.

Migrate setting about Simplified Chinese locale

cc7f837

Related to PR qbittorrent#17978

Migrate settings much earlier

41c3a8a

WebAPI: Expose "IS PRIVATE" flag

af91f4e

PR qbittorrent#18227. Closes qbittorrent#16052.

properties endpoint returns name/torrentID

bfda520

PR qbittorrent#18218.

Fix Pause icon

2204757

PR qbittorrent#18110.

NSIS: Set shortcut's workind dir to install path

ece8397

Adjust env variable for PDB discovery

9f743aa

sledgehammer999 force-pushed the stage_v4_5_x branch from 4b950e0 to 9f743aa Compare January 27, 2023 16:04

sledgehammer999 marked this pull request as draft January 27, 2023 16:07

sledgehammer999 marked this pull request as ready for review January 28, 2023 15:03

sledgehammer999 added 2 commits January 28, 2023 17:05

[WebUI] Use new pause icon color for toolbar/menu

1aebcd3

This the webui part of PR qbittorrent#18110

Use previous color for pause icon for indicating status

a32182f

Affects transfer list and status filters Related to PR qbittorrent#18110

glassez approved these changes Jan 28, 2023

View reviewed changes

This comment was marked as off-topic.

Sign in to view

sledgehammer999 merged commit 0a8d604 into qbittorrent:v4_5_x Feb 11, 2023

sledgehammer999 deleted the stage_v4_5_x branch February 11, 2023 22:54

This comment was marked as off-topic.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backports for v4_5_x part 2 #18452

Backports for v4_5_x part 2 #18452

sledgehammer999 commented Jan 24, 2023 •

edited

Loading

sledgehammer999 commented Jan 24, 2023

glassez commented Jan 25, 2023

xavier2k6 commented Jan 25, 2023

glassez commented Jan 25, 2023

xavier2k6 commented Jan 25, 2023 •

edited

Loading

sledgehammer999 commented Jan 25, 2023

sledgehammer999 commented Jan 25, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

sledgehammer999 commented Jan 25, 2023

Pentaphon commented Jan 26, 2023

sledgehammer999 commented Jan 27, 2023

sledgehammer999 commented Jan 28, 2023

Pentaphon commented Feb 10, 2023 •

edited

Loading

xavier2k6 commented Feb 10, 2023

This comment was marked as off-topic.

xavier2k6 commented Feb 15, 2023

This comment was marked as off-topic.

Backports for v4_5_x part 2 #18452

Backports for v4_5_x part 2 #18452

Conversation

sledgehammer999 commented Jan 24, 2023 • edited Loading

sledgehammer999 commented Jan 24, 2023

glassez commented Jan 25, 2023

xavier2k6 commented Jan 25, 2023

glassez commented Jan 25, 2023

xavier2k6 commented Jan 25, 2023 • edited Loading

sledgehammer999 commented Jan 25, 2023

sledgehammer999 commented Jan 25, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

sledgehammer999 commented Jan 25, 2023

Pentaphon commented Jan 26, 2023

sledgehammer999 commented Jan 27, 2023

sledgehammer999 commented Jan 28, 2023

Pentaphon commented Feb 10, 2023 • edited Loading

xavier2k6 commented Feb 10, 2023

This comment was marked as off-topic.

xavier2k6 commented Feb 15, 2023

This comment was marked as off-topic.

sledgehammer999 commented Jan 24, 2023 •

edited

Loading

xavier2k6 commented Jan 25, 2023 •

edited

Loading

Pentaphon commented Feb 10, 2023 •

edited

Loading