-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise description wordings #15459
Merged
Merged
Revise description wordings #15459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
added
WebUI
WebUI-related issues/changes
GUI
GUI-related issues/changes
Code cleanup
Clean up the code while preserving the same outcome
labels
Sep 13, 2021
Chocobo1
commented
Sep 13, 2021
@@ -390,7 +390,7 @@ | |||
<bool>true</bool> | |||
</property> | |||
<property name="text"> | |||
<string>&Disabled</string> | |||
<string>&Do nothing</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an option for "On Downloads Done" (other options are: Shutdown system, Hibernate System, etc.)
@@ -103,7 +103,7 @@ | |||
<div id="searchResultsFilters"> | |||
<input type="text" id="searchInNameFilter" placeholder="QBT_TR(Filter)QBT_TR[CONTEXT=SearchEngineWidget]" autocorrect="off" autocapitalize="none" /> | |||
|
|||
<span>QBT_TR(Results (showing)QBT_TR[CONTEXT=SearchEngineWidget] <span id="numSearchResultsVisible" class="numSearchResults">0</span> QBT_TR(out of)QBT_TR[CONTEXT=SearchEngineWidget] <span id="numSearchResultsTotal" class="numSearchResults">0</span>):</span> | |||
<span>QBT_TR(Results)QBT_TR[CONTEXT=SearchEngineWidget] (QBT_TR(showing)QBT_TR[CONTEXT=SearchEngineWidget] <span id="numSearchResultsVisible" class="numSearchResults">0</span> QBT_TR(out of)QBT_TR[CONTEXT=SearchEngineWidget] <span id="numSearchResultsTotal" class="numSearchResults">0</span>):</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the format for translation.
glassez
reviewed
Sep 13, 2021
thalieht
reviewed
Sep 13, 2021
PR updated, addressed comments. |
thalieht
reviewed
Sep 14, 2021
thalieht
previously approved these changes
Sep 15, 2021
glassez
reviewed
Sep 17, 2021
glassez
reviewed
Sep 17, 2021
glassez
reviewed
Sep 17, 2021
glassez
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code cleanup
Clean up the code while preserving the same outcome
GUI
GUI-related issues/changes
WebUI
WebUI-related issues/changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some comments on transifex and some of them sounds reasonable to me. And here is the result.