Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise description wordings #15459

Merged
merged 3 commits into from
Sep 19, 2021
Merged

Revise description wordings #15459

merged 3 commits into from
Sep 19, 2021

Conversation

Chocobo1
Copy link
Member

  • Revise description wordings
    I noticed some comments on transifex and some of them sounds reasonable to me. And here is the result.
  • WebUI: update authors page
  • Combine stream statements

@Chocobo1 Chocobo1 added WebUI WebUI-related issues/changes GUI GUI-related issues/changes Code cleanup Clean up the code while preserving the same outcome labels Sep 13, 2021
@Chocobo1 Chocobo1 added this to the 4.4.0 milestone Sep 13, 2021
@Chocobo1 Chocobo1 requested a review from a team September 13, 2021 04:13
@@ -390,7 +390,7 @@
<bool>true</bool>
</property>
<property name="text">
<string>&amp;Disabled</string>
<string>&amp;Do nothing</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an option for "On Downloads Done" (other options are: Shutdown system, Hibernate System, etc.)

@@ -103,7 +103,7 @@
<div id="searchResultsFilters">
<input type="text" id="searchInNameFilter" placeholder="QBT_TR(Filter)QBT_TR[CONTEXT=SearchEngineWidget]" autocorrect="off" autocapitalize="none" />

<span>QBT_TR(Results (showing)QBT_TR[CONTEXT=SearchEngineWidget] <span id="numSearchResultsVisible" class="numSearchResults">0</span> QBT_TR(out of)QBT_TR[CONTEXT=SearchEngineWidget] <span id="numSearchResultsTotal" class="numSearchResults">0</span>):</span>
<span>QBT_TR(Results)QBT_TR[CONTEXT=SearchEngineWidget] (QBT_TR(showing)QBT_TR[CONTEXT=SearchEngineWidget] <span id="numSearchResultsVisible" class="numSearchResults">0</span> QBT_TR(out of)QBT_TR[CONTEXT=SearchEngineWidget] <span id="numSearchResultsTotal" class="numSearchResults">0</span>):</span>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the format for translation.

src/gui/rss/automatedrssdownloader.ui Outdated Show resolved Hide resolved
src/gui/transferlistwidget.cpp Outdated Show resolved Hide resolved
@Chocobo1
Copy link
Member Author

PR updated, addressed comments.

src/app/application.cpp Outdated Show resolved Hide resolved
thalieht
thalieht previously approved these changes Sep 15, 2021
src/gui/aboutdialog.ui Outdated Show resolved Hide resolved
@Chocobo1 Chocobo1 merged commit ecd23d0 into qbittorrent:master Sep 19, 2021
@Chocobo1 Chocobo1 deleted the i18n branch September 19, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code cleanup Clean up the code while preserving the same outcome GUI GUI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants