Don't forget to start "watch timer"

[glassez]

Closes #15127.

[Chocobo1]

Please wait for the users to test it before merging.

[ghost]

Please back-port to 4.3.x.

[glassez]

Please back-port to 4.3.x.

Of course. Once it is merged into master.

[glassez]

Please wait for the users to test it before merging.

I can wait for users, of course. But don't code changes speak for themselves?
I'm afraid that the affected users will be able to test it only when it is merged and gets into the "unstable" repositories they use.

[Chocobo1]

But don't code changes speak for themselves?

Not sure what that means... no bugs or no regressions?

I can wait for users, of course.

You can wait for 2~3 days at most and if still no one tested it then you can proceed.

[FranciscoPombal]

@glassez

I was my understanding that we had all agreed that at a minimum, PR authors should ensure that the proposed changes actually work in the real world to the best of their abilities - code changes generally don't "speak for themselves". So, at least test it yourself under the circumstances described in the issue (if you haven't done so already).

In any case, I have issued a call for testing to the users affected by the issue: #15127 (comment).

You can wait for 2~3 days at most and if still no one tested it then you can proceed.

It is not enough to not test yourself, simply "wait for users to test it", and still merge after some time even if there is no positive confirmation whatsoever during that time.

Like I said, either actually wait for confirmation from others, or at the very least confirm it yourself, but don't just YOLO the change into the codebase.

[glassez]

But don't code changes speak for themselves?

Not sure what that means... no bugs or no regressions?

I mean, it turned out to be quite trivial to recognize and fix this error in the code after it became clear that it refers exactly to network folders (at least for me since I'm familiar with this part of codebase). Unfortunately, this "use case" remained outside the scope of my testing (and, it seems, all those who have used v4.4alpha builds since then).

[glassez]

#15127 (comment)
Well, it seems to be confirmed.