Remove the lockfile on exit #14997
Remove the lockfile on exit #14997
Conversation
|
@brvphoenix |
Delete the remaining files, when qbittorrent exits. If change the absolute path for the qbittorrent on portable mode, a different lockfile will be created and this file will not be deleted even if the qbittorrent exits. I think it is not reasonable. |
| @@ -130,6 +130,7 @@ bool QtLockedFile::unlock() | |||
| } | |||
|
|
|||
| m_lock_mode = NoLock; | |||
| remove(); | |||
There was a problem hiding this comment.
Please don't break file handling logic. Destroying file object (as well as unlocking file) shouldn't mean removing the file. You should explicitly unlock it and then remove in QtLocalPeer destructor instead.
There was a problem hiding this comment.
Should we follow QLockFile?
~QLockFile() will delete the lock file: https://doc.qt.io/qt-5/qlockfile.html#dtor.QLockFile
There was a problem hiding this comment.
Then it should not inherit the QFile, so as not to give the incorrect impression that it is just an extended version of the regular file handler.
There was a problem hiding this comment.
IMO, if we want to change it so deeply it can be done in separately.
brvphoenix
force-pushed
the
lockfile
branch
2 times, most recently
from
0371e3b
to
f39af7b
Compare
|
@brvphoenix |
Test on Windows and Linux (Ubuntu 20.04 LTS).