Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide correct error description in "upload mode" #14993

Merged
merged 2 commits into from
May 28, 2021

Conversation

glassez
Copy link
Member

@glassez glassez commented May 20, 2021

No description provided.

@FranciscoPombal
Copy link
Member

Is there any known reliable MRE for this? Since I can't reproduce the original problem, I can't test if this fixes it either...

@glassez
Copy link
Member Author

glassez commented May 20, 2021

I can't reproduce the original problem, I can't test if this fixes it either...

Neither do I. @An0n666 is been involved in a lot of related discussions, so he might be able to shed some light on that.

@ghost
Copy link

ghost commented May 20, 2021

Tested and it shows correct error message when there's not enough space in disk.
However I couldn't test other cases of I/O errors as I can't reproduce them.

@ghost
Copy link

ghost commented May 20, 2021

@glassez
If possible please update the notification as well. Currently the notification for file_error_alert contains repetative information and the actual reason of the error gets lost due to that - i.e - #14931
The notification should contain only the torrent name and the error code.

@ghost
Copy link

ghost commented May 21, 2021

Will qBt 4.4.0 update ship with libtorrent 2.0.x? In that case why aren't there any libtorrent 2.0.x builds in github actions?
I wanted to test if the issue with torrents stalling has been resolved in 2.0.x.

@ghost
Copy link

ghost commented May 23, 2021

BTW has anyone looked into this?
Couldn't load torrents queue from 'C:/Users/User/AppData/Local/qBittorrent/BT_backup/queue'. Error: The system cannot find the file specified.
This pops up in the errors log in master branch.

@xavier2k6
Copy link
Member

BTW has anyone looked into this?
Couldn't load torrents queue from 'C:/Users/User/AppData/Local/qBittorrent/BT_backup/queue'. Error: The system cannot find the file specified.
This pops up in the errors log in master branch.

This is due to the addition of the Experimental SQL database feature under advanced->Resume data storage type

If you save a torrent under that database type - error will disappear
It will re-appear though again if you go back to save as fastresume

@glassez
Copy link
Member Author

glassez commented May 23, 2021

BTW has anyone looked into this?
Couldn't load torrents queue from 'C:/Users/User/AppData/Local/qBittorrent/BT_backup/queue'. Error: The system cannot find the file specified.
This pops up in the errors log in master branch.

You mentioned it several times, but never once did you mention the circumstances of its occurrence. I've found the most likely cause, but I'm wondering if there are any pitfalls here. My guess is that it's either about the Queueing being disabled, or about the first run with a clean profile. Am I right?

@glassez
Copy link
Member Author

glassez commented May 23, 2021

This is due to the addition of the Experimental SQL database feature under advanced->Resume data storage type

If you save a torrent under that database type - error will disappear

Of course, since SQL resume data storage doesn't use this file.

@xavier2k6
Copy link
Member

My guess is that it's either about the Queueing being disabled

If I enable torrent queuing just once - no error in log appears anymore, even if I disable queuing/close program & re-open

@glassez
Copy link
Member Author

glassez commented May 23, 2021

BTW has anyone looked into this?
Couldn't load torrents queue from 'C:/Users/User/AppData/Local/qBittorrent/BT_backup/queue'. Error: The system cannot find the file specified.
This pops up in the errors log in master branch.

Should be fixed now.

@glassez glassez requested a review from Chocobo1 May 23, 2021 18:07
@xavier2k6
Copy link
Member

Should be fixed now.

👍 Confirmed fixed/doesn't display in logs.

Chocobo1
Chocobo1 previously approved these changes May 25, 2021
@ghost
Copy link

ghost commented May 25, 2021

@glassez
Something broke after your latest push. Now it's showing wrong error code for disk full.

image

The error code in log remains correct.

@glassez
Copy link
Member Author

glassez commented May 25, 2021

Now it's showing wrong error code for disk full.

Well, as they say - the best is the enemy of the good...

@An0n666
Is it reproducible each time?
And what happens if you wait some time without freeing the disk space?
Also can you hide such torrent (e.g. by selecting another category) and then show it again?

@ghost
Copy link

ghost commented May 26, 2021

Is it reproducible each time?

Yes!

And what happens if you wait some time without freeing the disk space?

Same error!

Also can you hide such torrent (e.g. by selecting another category) and then show it again?

Same results! The status message doesn't change.

@glassez
Copy link
Member Author

glassez commented May 27, 2021

@An0n666
Should be fixed now. Please test it.

@glassez glassez requested a review from Chocobo1 May 27, 2021 05:59
@ghost
Copy link

ghost commented May 27, 2021

@An0n666
Should be fixed now. Please test it.

Working fine now!
However, the fullstop doesn't show up in the status message after the error message string.

Capture

@glassez
Copy link
Member Author

glassez commented May 27, 2021

Working fine now!
However, the fullstop doesn't show up in the status message after the error message string.

Fixed.
Weird... how did it even compile with this error in the code?..

@ghost
Copy link

ghost commented May 28, 2021

Fixed.

Confirmed.

@glassez glassez merged commit 1c34635 into qbittorrent:master May 28, 2021
@glassez glassez deleted the file-error branch May 28, 2021 05:55
@glassez
Copy link
Member Author

glassez commented May 28, 2021

@An0n666
Thank you for testing!

IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request May 30, 2021
Provide correct error description in "upload mode"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants