Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Qt translations and add new qbt translations #14934

Merged
merged 3 commits into from
May 23, 2021
Merged

Update Qt translations and add new qbt translations #14934

merged 3 commits into from
May 23, 2021

Conversation

sledgehammer999
Copy link
Member

No description provided.

@sledgehammer999 sledgehammer999 added the Translations Related to i18n or Transifex label May 7, 2021
@sledgehammer999 sledgehammer999 added this to the 4.4.0 milestone May 7, 2021
@sledgehammer999 sledgehammer999 mentioned this pull request May 7, 2021
Merged
@sledgehammer999
Copy link
Member Author

In case anyone wonders: I tested if the GUI/WEBUI changed when choosing all these new languages.

@BouRock
Copy link
Contributor

BouRock commented May 7, 2021

@sledgehammer999 Thank you

@glassez glassez changed the title Updated Qt translations and add new qbt translations Update Qt translations and add new qbt translations May 8, 2021
@Chocobo1
Copy link
Member

Chocobo1 commented May 8, 2021

I recall there was a discussion about including the stubs: #12138 (comment)
IIRC, the conclusion was not to include them, i.e. those *.qm that are ~10 bytes shouldn't be included.

@sledgehammer999
Copy link
Member Author

sledgehammer999 commented May 8, 2021 •
edited
Loading

IIRC, the conclusion was not to include them, i.e. those *.qm that are ~10 bytes shouldn't be included.

Github's representation is fooling you. The first commit updates old files and github shows the difference in bytes. Not the total size. Those .qm files aren't stubs. They are KB in size.

@Chocobo1
Copy link
Member

Chocobo1 commented May 9, 2021

Github's representation is fooling you. The first commit updates old files and github shows the difference in bytes. Not the total size. Those .qm files aren't stubs. They are KB in size.

Oops, you are right.

@sledgehammer999 sledgehammer999 merged commit 34be8c9 into qbittorrent:master May 23, 2021
@sledgehammer999 sledgehammer999 deleted the translations branch May 23, 2021 18:59
IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request May 30, 2021
@sledgehammer999
Merge pull request qbittorrent#14934 from sledgehammer999/translations
7af9336 
Update Qt translations and add new qbt translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez approved these changes

@Chocobo1 Chocobo1 Chocobo1 approved these changes

Assignees
No one assigned
Labels
Translations Related to i18n or Transifex
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sledgehammer999 @BouRock @Chocobo1 @glassez