Bump copyright year #14156
Merged
Bump copyright year #14156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glassez
approved these changes
Jan 5, 2021
glassez
reviewed
Jan 5, 2021
| @@ -60,7 +60,7 @@ AboutDialog::AboutDialog(QWidget *parent) | |||
| "</table>" | |||
| "</p>") | |||
| .arg(tr("An advanced BitTorrent client programmed in C++, based on Qt toolkit and libtorrent-rasterbar.") | |||
| , tr("Copyright %1 2006-2020 The qBittorrent project").arg(QString::fromUtf8(C_COPYRIGHT)) | |||
| , tr("Copyright %1 2006-2021 The qBittorrent project").arg(QString::fromUtf8(C_COPYRIGHT)) | |||
There was a problem hiding this comment.
Guys, does the problem of having UTF-8 characters directly in strings still exist?
There was a problem hiding this comment.
IIRC it was due to something about MSVC that @Chocobo1 had encountered in the past. I didn't have any problem.
There was a problem hiding this comment.
Guys, does the problem of having UTF-8 characters directly in strings still exist?
Yes and MS still let it exist.
If this is a nuisance, we can turn off that warning flag.
There was a problem hiding this comment.
If this is a nuisance, we can turn off that warning flag.
Does it bring any real trouble beyond a warning? If not, I'd rather get rid of this workaround by using character substitution from a separate file.
Chocobo1
approved these changes
Jan 5, 2021
IceCodeNew
pushed a commit
to IceCodeNew/qBittorrent-Enhanced-Edition
that referenced
this pull request
Jan 6, 2021
Bump copyright year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.