Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set name to sheets #25

Closed
JWo1F opened this issue Feb 20, 2017 · 5 comments
Closed

Cannot set name to sheets #25

JWo1F opened this issue Feb 20, 2017 · 5 comments

Comments

@JWo1F
Copy link

JWo1F commented Feb 20, 2017

Hi! I want to use custom names for my sheets. But I can't because it need to name "Sheet" + index.
It's critical bug, I think.

https://github.com/Luxurioust/excelize/blob/master/cell.go#L14
https://github.com/Luxurioust/excelize/blob/master/sheet.go#L22
https://github.com/Luxurioust/excelize/blob/master/sheet.go#L35

@JWo1F JWo1F changed the title Cannot set name to sheet Cannot set name to sheets Feb 20, 2017
@xuri xuri self-assigned this Feb 23, 2017
@JWo1F
Copy link
Author

JWo1F commented Mar 2, 2017

@Luxurioust how to progress?

@xuri
Copy link
Member

xuri commented Mar 3, 2017

@JWo1F Thank you very much for your comments. I will commit for this issue as soon as possible.

xuri added a commit that referenced this issue Apr 1, 2017
Fix return index error in function `GetSheetMap()`;
Fix return worksheet name error in function `GetSheetName()`;
go test updated
@xuri
Copy link
Member

xuri commented Apr 1, 2017

@JWo1F I have add new function GetSheetIndex() to provides a method to get worksheet index by name. You can also use the GetSheetMap() function to get all sheets index and name map. Why not add set cell value by sheet name support for function SetCellValue() directly or add an new export function? I think that to find the index by worksheet name will use a lot of types of inference internally it will affect performance. Please tell me if there is a better idea.

@luca-moser
Copy link

luca-moser commented Jun 26, 2017

@Luxurioust there is still a bug, the sheet name must be modified after cells were written to it, otherwise the generated excel file is invalid.

@xuri
Copy link
Member

xuri commented Jun 26, 2017

@luca-moser Sorry, I don't understand what you mean, could you provide file attachments or some codes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants