Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied code #1

Closed
mafredri opened this issue Aug 31, 2016 · 2 comments
Closed

Copied code #1

mafredri opened this issue Aug 31, 2016 · 2 comments

Comments

@mafredri
Copy link

Hey,

I just came across your project and noticed there is a lot of copied code from tealeg/xlsx without attribution. Especially xmlSharedStrings.go which is a direct copy paste of tealeg/xlsx xmlSharedStrings.go, comments and all.

It's nice to see more xlsx action in the Golang world, but have you considered just contributing to tealeg/xlsx instead?

@xuri
Copy link
Member

xuri commented Aug 31, 2016

Thanks for your issue, I'm sorry I didn't comments some code copy from tealeg/xlsx. I have update README file and add comments in all file for this issue. tealeg/xlsx provided much more function. I'm very glad to contribute code to it. Sometimes I need to save file without losing original charts of XLSX, so I had rewrite a simple library.

@xuri xuri closed this as completed Aug 31, 2016
@mafredri
Copy link
Author

Thanks for amending it so quickly 👍 !

I can also see a real benefit in being able to edit the original without modifying it. I've actually played with this idea myself, especially for really large xlsx files that do not fit in memory. In those cases it would be need to be disk-backed whilst still permitting editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants