This closes #1906, fix a v2.8.1 regression bug introduced by commit d…

…9a0da7

- Fix incorrect cell value written if save multiple times
- Update unit tests

excelize_test.go

@@ -208,6 +208,30 @@ func TestSaveFile(t *testing.T) {
  assert.NoError(t, err)
  assert.NoError(t, f.Save())
  assert.NoError(t, f.Close())
+
+ t.Run("for_save_multiple_times", func(t *testing.T) {
+ {
+ f, err := OpenFile(filepath.Join("test", "TestSaveFile.xlsx"))
+ assert.NoError(t, err)
+ assert.NoError(t, f.SetCellValue("Sheet1", "A20", 20))
+ assert.NoError(t, f.Save())
+
+ assert.NoError(t, f.SetCellValue("Sheet1", "A21", 21))
+ assert.NoError(t, f.Save())
+ assert.NoError(t, f.Close())
+ }
+ {
+ f, err := OpenFile(filepath.Join("test", "TestSaveFile.xlsx"))
+ assert.NoError(t, err)
+ val, err := f.GetCellValue("Sheet1", "A20")
+ assert.NoError(t, err)
+ assert.Equal(t, "20", val)
+ val, err = f.GetCellValue("Sheet1", "A21")
+ assert.NoError(t, err)
+ assert.Equal(t, "21", val)
+ assert.NoError(t, f.Close())
+ }
+ })
 }
 
 func TestSaveAsWrongPath(t *testing.T) {

sheet.go

@@ -167,7 +167,7 @@ func (f *File) workSheetWriter() {
  _, ok := f.checked.Load(p.(string))
  if ok {
  f.Sheet.Delete(p.(string))
- f.checked.Store(p.(string), false)
+ f.checked.Delete(p.(string))
  }
  buffer.Reset()
  }