Merge pull request integrations#15 from integrations/escaping

Fix unnecessary escaping
qatalog · Mar 30, 2018 · 60fbcaf · 60fbcaf
2 parents 4115f80 + eccf1a7
commit 60fbcaf
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -11,6 +11,14 @@ const service = new TurnDown({
  linkStyle: 'slack'
 })
 
+// override escaping
+// https://api.slack.com/docs/message-formatting#how_to_escape_characters
+service.escape = (string) => (
+ string.replace('&', '&amp;')
+ .replace('<', '&lt;')
+ .replace('>', '&gt;')
+)
+
 service.use(strikethrough)
 service.use(taskListItems)
 

diff --git a/test/fixtures/a.mrkdwn b/test/fixtures/a.mrkdwn
@@ -1,3 +1,4 @@
 <a href="https://example.com">Hello</a>
+<a href="https://example.com">Upcoming_Distrust_Actions wiki</a>
 ====
-<https://example.com|Hello>
+<https://example.com|Hello> <https://example.com|Upcoming_Distrust_Actions wiki>
diff --git a/test/fixtures/escaping.mrkdwn b/test/fixtures/escaping.mrkdwn
@@ -0,0 +1,9 @@
+<h2>1. First things first</h2>
+<p>[Effort: M, Impact: L]</p>
+<p>&lt;hello&gt;</p>
+====
+*1. First things first*
+
+[Effort: M, Impact: L]
+
+&lt;hello&gt;