Make pyvista/kitware team code owners to trame modules #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyvista-bot
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5325 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 134 134
Lines 22716 22716
=======================================
Hits 21854 21854
Misses 862 862 |
|
This is a good idea. I have no confidence to change |
annehaley
previously approved these changes
Dec 12, 2023
|
This is a great idea, thanks for putting this together, @banesullivan. |
|
Sounds good to me too, good idea! |
|
@pyvista-bot LGTM |
pyvista-bot
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pyvista/kitware, I recently set up this team to house all our excellent collaborators at Kitware! I'd like to use this group to ping you folks when critical but specifically to automatically assign someone from Kitware as a reviewer anytime the trame-related modules in PyVista are adjusted.
Does this sound good to you all? Feel free to add other sections of the code you'd like to take ownership of!