Fix EWA default for 'weight_delta_max' to match docstring #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, turns out it was wrong in the legacy resampler too. Fixed in both now. |
Codecov Report
@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 69 69
Lines 12394 12394
=======================================
Hits 11686 11686
Misses 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in pytroll/python-geotiepoints#38 I discovered that the default
weight_delta_maxin the dask EWA code did not match the docstring. The docstring is correct for MODIS data and matches what has been in the EWA algorithm forever (it was originally written for MODIS code).I really don't want to add a test for this.
git diff origin/main **/*py | flake8 --diff