Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect extents for DynamicAreaDefinition with 'modify_crs' antimeridian mode #446

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jul 29, 2022

Test driven development doesn't help when your expected output is wrong.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese added the bug label Jul 29, 2022
@djhoese djhoese requested a review from mraspaud July 29, 2022 00:30
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #446 (93e0f3b) into main (6664669) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files          68       68           
  Lines       12346    12349    +3     
=======================================
+ Hits        11632    11635    +3     
  Misses        714      714           
Flag Coverage Δ
unittests 94.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/test/test_geometry.py 99.51% <ø> (ø)
pyresample/geometry.py 87.15% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 94.064% when pulling 93e0f3b on djhoese:bugfix-antimeridian-modify-crs into 6664669 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mraspaud mraspaud merged commit 7ce58cf into pytroll:main Jul 29, 2022
@djhoese djhoese deleted the bugfix-antimeridian-modify-crs branch July 29, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants