Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better dask handling to DynamicAreaDefinitions #346

Merged
merged 6 commits into from
Apr 14, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 22, 2021

See #344 for the details.

@djhoese djhoese self-assigned this Mar 22, 2021
@djhoese djhoese changed the title Cleanup test_geometry.py to use smarter skipifs Add better dask handling to DynamicAreaDefinitions Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #346 (81bc10b) into master (9801978) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   93.06%   93.29%   +0.23%     
==========================================
  Files          48       48              
  Lines        9843    10009     +166     
==========================================
+ Hits         9160     9338     +178     
+ Misses        683      671      -12     
Flag Coverage Δ
unittests 93.29% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/geometry.py 86.52% <100.00%> (+1.00%) ⬆️
pyresample/test/test_geometry.py 99.26% <100.00%> (+0.74%) ⬆️
pyresample/utils/proj4.py 100.00% <100.00%> (ø)
pyresample/utils/__init__.py 83.52% <0.00%> (-0.20%) ⬇️
pyresample/test/test_dask_ewa.py 98.85% <0.00%> (+0.01%) ⬆️
pyresample/ewa/dask_ewa.py 91.21% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9801978...81bc10b. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 22, 2021

Coverage Status

Coverage increased (+0.2%) to 93.285% when pulling 81bc10b on djhoese:feature-dynamic-area-def-dask into 9801978 on pytroll:master.

pyresample/geometry.py Outdated Show resolved Hide resolved
@djhoese
Copy link
Member Author

djhoese commented Mar 22, 2021

@mraspaud Well it works, but I'm not really happy with how gross the code got.

@djhoese djhoese marked this pull request as ready for review March 22, 2021 22:33
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions to start with

pyresample/test/test_geometry.py Outdated Show resolved Hide resolved
pyresample/utils/proj4.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Apr 13, 2021

Congratulations 🎉. DeepCode analyzed your code in 3.517 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

pyresample/utils/proj4.py Outdated Show resolved Hide resolved
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit f71a474 into pytroll:master Apr 14, 2021
@djhoese djhoese deleted the feature-dynamic-area-def-dask branch April 14, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of dask arrays in DynamicAreaDefinition
4 participants