Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EWA resampling when the result is all fill values #343

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 22, 2021

This was a bug I discovered at the same time I found #342, but had a really difficult time reproducing. The main piece of code that is effected is only called when dask determines that it should call the "aggregate" function of the reduction with a specific result from the previous "combination" calls. I was able to force this by making the input one single chunk.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@djhoese djhoese added the bug label Mar 22, 2021
@djhoese djhoese requested a review from mraspaud March 22, 2021 01:47
@djhoese djhoese self-assigned this Mar 22, 2021
pyresample/test/test_dask_ewa.py Outdated Show resolved Hide resolved
pyresample/test/test_dask_ewa.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #343 (7f5f272) into master (30422e6) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 7f5f272 differs from pull request most recent head 8a5e1ee. Consider uploading reports for the commit 8a5e1ee to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   92.99%   93.03%   +0.04%     
==========================================
  Files          48       48              
  Lines        9798     9813      +15     
==========================================
+ Hits         9112     9130      +18     
+ Misses        686      683       -3     
Flag Coverage Δ
unittests 93.03% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/ewa/dask_ewa.py 90.71% <100.00%> (+1.26%) ⬆️
pyresample/test/test_dask_ewa.py 98.84% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30422e6...8a5e1ee. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 22, 2021

Coverage Status

Coverage increased (+0.04%) to 93.029% when pulling 8a5e1ee on djhoese:bugfix-dask-ewa-empty-chunk into 30422e6 on pytroll:master.

@ghost
Copy link

ghost commented Mar 22, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 68414d7 into pytroll:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants