Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appveyor CI in favor of travis Windows and add Python 3.9 wheels #310

Merged
merged 12 commits into from
Nov 11, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 5, 2020

Appveyor support is deprecated by ci-helpers which we are using to easily download and install conda packages. We already have Windows being tested on travis but it is an allowed failure. This PR removes appveyor and moves the Windows environment out of the allowed failure on Travis.

@djhoese djhoese requested review from mraspaud and pnuu November 5, 2020 15:14
@djhoese djhoese self-assigned this Nov 5, 2020
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #310 (4b175b9) into master (8b45836) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files          45       45           
  Lines        9146     9146           
=======================================
  Hits         8475     8475           
  Misses        671      671           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b45836...4b175b9. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.642% when pulling e13cebb on djhoese:ci-remove-appveyor into 8b45836 on pytroll:master.

@coveralls
Copy link

coveralls commented Nov 5, 2020

Coverage Status

Coverage increased (+0.02%) to 92.663% when pulling 4b175b9 on djhoese:ci-remove-appveyor into 8b45836 on pytroll:master.

@djhoese
Copy link
Member Author

djhoese commented Nov 6, 2020

One downside I'm realizing after all of these changes is that Python 3.9 wheels still aren't built because we are waiting on a pykdtree wheel (installing from source currently fails on the wheel docker images).

@djhoese
Copy link
Member Author

djhoese commented Nov 6, 2020

This is ready for review otherwise.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese changed the title Remove appveyor CI in favor of travis Windows Remove appveyor CI in favor of travis Windows and add Python 3.9 wheels Nov 11, 2020
@djhoese djhoese merged commit 48c5fb0 into pytroll:master Nov 11, 2020
@djhoese djhoese deleted the ci-remove-appveyor branch November 11, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants