Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpm building for python 3 #255

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Conversation

adybbroe
Copy link
Contributor

Fix so that it is possible to make an rpm package for Python 3 (only)

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

Signed-off-by: Adam.Dybbroe <[email protected]>
@adybbroe adybbroe added the bug label Feb 24, 2020
@adybbroe adybbroe self-assigned this Feb 24, 2020
@adybbroe adybbroe marked this pull request as ready for review February 24, 2020 13:20
@coveralls
Copy link

coveralls commented Feb 24, 2020

Coverage Status

Coverage remained the same at 91.902% when pulling 92d171c on adybbroe:python3-bdist into ef22d21 on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #255 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          42       42           
  Lines        8076     8076           
=======================================
  Hits         7424     7424           
  Misses        652      652           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef22d21...92d171c. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented Mar 19, 2020

I assume this means that RPMs can be made for CentOS versions where Python 3 is the default. Merging now with the assumption that this doesn't break something further down the line.

@djhoese djhoese merged commit 75ca61f into pytroll:master Mar 19, 2020
@djhoese djhoese changed the title Fix for python3 rpm-build Fix rpm building for python 3 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants