Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyximports from gradient search #245

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 22, 2019

pyximports make the import of gradient resampler fail if cython isn't installed

  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@mraspaud mraspaud added the bug label Dec 22, 2019
@mraspaud mraspaud self-assigned this Dec 22, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 91.253% when pulling 0857d67 on mraspaud:fix-gradient into 4afcc5f on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #245 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   91.27%   91.27%   -0.01%     
==========================================
  Files          42       42              
  Lines        8245     8243       -2     
==========================================
- Hits         7526     7524       -2     
  Misses        719      719
Impacted Files Coverage Δ
pyresample/resampler.py 34.78% <ø> (ø) ⬆️
pyresample/test/test_gradient.py 93.12% <ø> (ø) ⬆️
pyresample/gradient/__init__.py 94.49% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4afcc5f...0857d67. Read the comment docs.

@mraspaud mraspaud merged commit 4064b5a into pytroll:master Dec 22, 2019
@mraspaud mraspaud deleted the fix-gradient branch December 22, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants