Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Example for Regular Lat-Lon Grid #204

Merged
merged 11 commits into from
Sep 12, 2019
Merged

Add Example for Regular Lat-Lon Grid #204

merged 11 commits into from
Sep 12, 2019

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Aug 12, 2019

After introducing a couple of students/interns to pyresample I found that it would be useful to have an example explaining how to get the area definition for a given regular lat-lon grid.

I also separated the area definition examples into separate code blocks to improve the readability.

  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@djhoese
Copy link
Member

djhoese commented Aug 12, 2019

Technically eqc is not a "lat/lon" grid, right? It is in meters. A lat/lon grid would be +proj=latlong.

@sfinkens
Copy link
Member Author

Yes, good point. Changed it to latlong.

@sfinkens
Copy link
Member Author

Hm, but now the example doesn't fit the "...even if the projection space is defined in meters" anymore. I'll just add an extra sentence for that.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files          39       39           
  Lines        7161     7161           
=======================================
  Hits         6246     6246           
  Misses        915      915

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be0871...21185ca. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.195% when pulling 21185ca on sfinkens:doc-geometry-utils into 9be0871 on pytroll:master.

@mraspaud mraspaud merged commit 2662b43 into pytroll:master Sep 12, 2019
@sfinkens sfinkens deleted the doc-geometry-utils branch October 22, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants