Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml area loading when projection is latlong (units degrees) #167

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 11, 2019

YAML parsing was assuming meters for units even for latlong projections.

@pnuu @wroberts4 Can you verify that this fixes the issue brought up on slack.

YAML parsing was assuming meters for units even for latlong projections.
@djhoese
Copy link
Member Author

djhoese commented Mar 11, 2019

Ok, I made this PR from pycharm. Starting to figure out how it works...hopefully this is the last time I make a branch on the main repository.

@djhoese djhoese requested review from mraspaud and pnuu March 11, 2019 13:37
@djhoese djhoese self-assigned this Mar 11, 2019
@djhoese djhoese added the bug label Mar 11, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 85.95% when pulling 1a947bb on bugfix-latlong-units into aba7897 on master.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #167 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   85.97%   85.98%   +<.01%     
==========================================
  Files          37       37              
  Lines        6551     6555       +4     
==========================================
+ Hits         5632     5636       +4     
  Misses        919      919
Impacted Files Coverage Δ
pyresample/area_config.py 86.74% <100%> (ø) ⬆️
pyresample/test/test_utils.py 98.65% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba7897...1a947bb. Read the comment docs.

@djhoese djhoese merged commit 936e60c into master Mar 14, 2019
@djhoese djhoese deleted the bugfix-latlong-units branch March 14, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants