fix assert_run_python_script on Windows #7346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Reviewed By: vmoens Differential Revision: D44416618 fbshipit-source-id: 21cb1238610a295a19f5d27cf55c9e89520b76c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests that use
assert_run_python_script, fail on Windows. For example: https://app.circleci.com/pipelines/github/pytorch/vision/23631/workflows/9af6160b-70a4-480e-9593-0800b2c67547/jobs/1842615I think the issue is that Windows does not allow to access a file from a another process while it is still opened. Instead of a temporary file that deletes itself after closing it, this PR adds a temporary directory that does the same. Inside the directory we can write to a regular file and close that before we start the subprocess.