[FBcode->GH] Allow all torchvision test rules to run with RE #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test rules are ignored in GPU CI machines Summary: This diff allows all torchvision test targets to run with RE, which allows the `IN_RE_WORKER` variable to be accurate and addresses https://www.internalfb.com/diff/D29105975?dst_version_fbid=579903510079850&transaction_fbid=282918386905496 Now, **all** CPU-only tests are ignored in the GPU contbuild (pytorch_vision-gpu). Previously, the CPU-only tests in files that had **no** CUDA tests were still run on GPU CI machines. Only the CPU-only tests in files that also had some CUDA tests were properly ignored. Note that just because we allow all test rules to run with RE doesn't mean they'll always be run with RE. Namely, they'll only run with RE when invoked from the pytorch_vision-gpu contbuild. They won't run with RE when invoked with the pytorch_vision (CPU-only) contbuild. Note 2: I had to deactivate RE for `test_image.py`. This is only temporary until nbjpeg is properly supported, see comments. Reviewed By: fmassa Differential Revision: D29132838 fbshipit-source-id: 206b0a635d723abf9930c6c71f4b35429a40b508
|
Hey @NicolasHug, @fmassa! You approved or merged this PR, but no labels were added. |
|
tagging as code quality since it's mostly comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an import from an internal diff. In GH it mostly adds comments to the code.