Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print out "Ignoring patterns" for download #625

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Print out "Ignoring patterns" for download #625

merged 1 commit into from
Mar 31, 2024

Conversation

joecummings
Copy link
Contributor

@joecummings joecummings commented Mar 31, 2024 •
edited
Loading

Context

  • Increases visibility into which files WON'T be download. An ask from @kartikayk

Closes #411

Changelog

  • Add print statement
  • Update test

Test plan

  • CI

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/625

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0a8701f with merge base 73647e2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2024
kartikayk
kartikayk approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@kartikayk kartikayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@joecummings joecummings merged commit 57602f7 into main Mar 31, 2024
20 checks passed
@joecummings joecummings deleted the add-ignore-files-to-output branch April 1, 2024 00:56
tcapelle pushed a commit to tcapelle/torchtune that referenced this pull request Apr 5, 2024
@joecummings
Print out "Ignoring patterns" for download (pytorch#625)
f60ebb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikayk kartikayk kartikayk approved these changes

@ebsmothers ebsmothers Awaiting requested review from ebsmothers

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discussion] "tune download" behavior is unintuitive
3 participants
@joecummings @kartikayk @facebook-github-bot