Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support torch 2.1 dtensor #82

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

support torch 2.1 dtensor #82

wants to merge 4 commits into from

Conversation

JsBlueCat
Copy link

@JsBlueCat JsBlueCat commented Mar 5, 2024

feat(dmodule): support parallelized dtensor init

feat(dtensor): support for query random op

feat(dtensor): support deferred init on device

What does this PR do? Please describe:

hello, i add some support for torch2.1 and support torch DTensor support for defer_init and marterialize

Does your PR introduce any breaking changes? If yes, please list them:
List of all backwards-incompatible API changes.

Check list:

  • Was this discussed and approved via a GitHub issue? (not for typos or docs)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, or minor internal changes)

feat(dmodule): support parallelized dtensor init

feat(dtensor): support for query random op

feat(dtensor): support deferred init on device
@facebook-github-bot
Copy link

Hi @JsBlueCat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@JsBlueCat JsBlueCat changed the title support torch 2.1 support torch 2.1 dtenosr Mar 5, 2024
@JsBlueCat JsBlueCat changed the title support torch 2.1 dtenosr support torch 2.1 dtensor Mar 5, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests for new features

@wanchaol
Copy link

@cbalioglu @rohan-varma @H-Huang any of you want to give a review on this? If not I can take a snap after the tests added

fix generate op is random op when deferred init is set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants