Use new PyObjectSlot API #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesr66a
requested review from
cbalioglu,
rohan-varma and
H-Huang
as code owners
facebook-github-bot
added
the
CLA Signed
|
Hey @jamesr66a good to see you here! :) Thanks a lot for the fix. I believe I should clean up the CI first. Since I moved to FAIR the maintenance of torchdistx has lagged quite a bit. Let me do a spring cleanup today and unblock the pipeline. |
jamesr66a
commented
Mar 23, 2023
jamesr66a
force-pushed
the
fix_pyobj_slot
branch
from
eb86016
to
0857e8c
Compare
|
Hey @cbalioglu any update? :) |
|
Hey @jamesr66a , I partially fixed the CI which required me to include your code changes in the commit as well. So this PR is not "relevant" anymore, but I still have to fix the conda builds to unblock the nightly CI. If you are building stuff from source, it should work now. If you require the pre-built conda package, I will have another attempt on Monday. Apparently PT2 changed how CUDA is bundled which breaks our conda packaging script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates C++ code based on BC-breaking change pytorch/pytorch#92169