Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated requirements for future distributed tests run #37

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

aovladi
Copy link
Contributor

@aovladi aovladi commented Jul 7, 2022

expecttest is a required module by torch/testing/_internal/common_utils.py, which I need in future to pass CI checks.
This PR adds expecttest into requirements-devel.txt

I've tried a to install torchdistx from source with the updated requirements-devel.txt and installation is successful existing tests work.

Check list:

  • Was this discussed and approved via a GitHub issue? (not for typos or docs)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary) - Not necessary
  • Did you write any new necessary tests? - Not necessary
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, or minor internal changes)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2022
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cc @cbalioglu as FYI

Copy link
Contributor

@cbalioglu cbalioglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbalioglu cbalioglu merged commit 6fa1eb1 into main Jul 7, 2022
@cbalioglu cbalioglu deleted the updated_requirements branch July 7, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants