Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to v0.2.0 #30

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Bump to v0.2.0 #30

merged 2 commits into from
Jun 29, 2022

Conversation

cbalioglu
Copy link
Contributor

This PR:

  • Bumps the version to 0.2.0
  • Introduces support for PyTorch 1.12 and CUDA 11.6
  • Introduces support for Python 3.10

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 29, 2022
rohan-varma
rohan-varma approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, only a minor question

.github/workflows/nightly.yaml
deploy:
name: Deploy
if: github.event_name == 'schedule' || github.event.inputs.deploy == 'true'
needs: [build_doc, test_wheel_cu113, test_conda_cu113]
needs: [build_doc, test_wheel_cu116, test_conda_cu116]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why do we remove test_wheel_cu113, test_conda_cu113 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not removing them. We just add a new "node" (test_{wheel,conda}_cu116) in-between test_{wheel,conda}_cu113 and deploy. Think of it as inserting a new node to a linked list. test_xx_cu116 declares its needs as test_xx_cu113 (see a couple lines above this one) and likewise deploy declares its needs as test_xx_cu116.

.github/workflows/release.yaml Show resolved Hide resolved
@cbalioglu cbalioglu merged commit 95c7dd0 into pytorch:main Jun 29, 2022
@cbalioglu cbalioglu deleted the v0.2.0 branch June 29, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-varma rohan-varma rohan-varma approved these changes

@H-Huang H-Huang Awaiting requested review from H-Huang H-Huang is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cbalioglu @rohan-varma @facebook-github-bot