Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Multiagent API in vmas #983

Merged
merged 82 commits into from
Apr 6, 2023

Conversation

matteobettini
Copy link
Contributor

Implementation of #943 in vmas

The agent dimension has been moved outside the batch_size.

I will use this simulator to implement a multi-agent training example in torch rl

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2023
@matteobettini matteobettini marked this pull request as draft March 21, 2023 11:14
@matteobettini matteobettini changed the title Multiagent API in vmas [Feature] Multiagent API in vmas Apr 6, 2023
@matteobettini matteobettini marked this pull request as ready for review April 6, 2023 10:30
@matteobettini
Copy link
Contributor Author

matteobettini commented Apr 6, 2023

@vmoens this should be ready.

It will be used in multiagent examples like #1027

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit f167c55 into pytorch:main Apr 6, 2023
@matteobettini matteobettini deleted the multi_agent_training_vmas branch April 6, 2023 12:46
albertbou92 pushed a commit to PyTorchRL/rl that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants