Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature, Refactor] Iterable replay buffers #968

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Mar 15, 2023

Description

Implements an __iter__ method for replay buffer.
The goal is to be able to go through a replay buffer with a for loop.
The sampler without repetition should lead to a finite loop, and the drop-last argument should match the behaviour of dataloaders.

TODO:

  • Implement tests of the feature
    • combinations of replay buffers with various samplers
    • check that the behaviour of the sampler without repetition matches what's expected
  • Document the feature

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2023
@vmoens vmoens added enhancement New feature or request bc breaking backward compatibility breaking change Refactoring Refactoring of an existing feature labels Mar 15, 2023
@vmoens vmoens merged commit c8c9157 into main Mar 15, 2023
@vmoens vmoens deleted the refactor_rb_sample branch March 15, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc breaking backward compatibility breaking change CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request Refactoring Refactoring of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants