[Feature] Replaced device_safe() with device
#485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`device_safe()` was removed from `TensorDict` classes. It was replaced with `device`, which no longer throws an exception when `_device` is `None`.
|
Failed CI reports next error: There is no direct connection between changes in this pull request with this functionality. I don't see related open issues either. What is the the procedure in this case? |
you can just merge main, this has just been fixed |
# Conflicts: # torchrl/data/tensordict/tensordict.py
`device_safe()` was removed from `TensorDict` classes. It was replaced with `device`, which no longer throws an exception when `_device` is `None`.
Test no longer expects the error. It verifies that `device` of the dictionary is `None` when not set.
vmoens
reviewed
Sep 23, 2022
vmoens
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device_safe()was removed fromTensorDictclasses. It was replaced withdevice, which no longer throws an exception when_deviceisNone.Description
device_safe()method was removed from allTensorDictclasses.TensorDict.deviceproperty no longer throws an exception and returnsNoneifself._deviceisNone.SavedTensorDictimplicitly copiesdeviceof the source dictionary, unlessdeviceis provided explicitly.Motivation and Context
close #455
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!