Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] TransformedEnv attributes inheritance #467

Merged
merged 2 commits into from
Sep 20, 2022
Merged

[BugFix] TransformedEnv attributes inheritance #467

merged 2 commits into from
Sep 20, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 20, 2022 •
edited
Loading

Description

Fixes the setting of env.batch_locked and env._inplace_update for TransformedEnv, as passing them through a Pipe caused a attribute error when calling __new__.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2022
@vmoens vmoens added the bug Something isn't working label Sep 20, 2022
@vmoens vmoens merged commit 58d82f1 into main Sep 20, 2022
@vmoens vmoens deleted the batch_locked_trsf branch September 20, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot