Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix test_specs.py #2214

Merged
merged 2 commits into from
Jun 7, 2024
Merged

[BugFix] Fix test_specs.py #2214

merged 2 commits into from
Jun 7, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 7, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2214

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 16 Unrelated Failures

As of commit 6c25ad7 with merge base 64c0b8e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2024
@vmoens vmoens added the Tests Incomplete or broken unit tests label Jun 7, 2024
@vmoens vmoens merged commit d934153 into main Jun 7, 2024
27 of 42 checks passed
@vmoens vmoens deleted the fix-tests-specs branch June 7, 2024 06:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1153s 58.8900ms 16.9808 Ops/s 18.0902 Ops/s $\textbf{\color{#d91a1a}-6.13\%}$
test_sync 36.6464ms 31.0858ms 32.1690 Ops/s 31.2548 Ops/s $\color{#35bf28}+2.92\%$
test_async 48.2356ms 28.4952ms 35.0936 Ops/s 34.1249 Ops/s $\color{#35bf28}+2.84\%$
test_simple 0.4708s 0.3972s 2.5179 Ops/s 2.6511 Ops/s $\textbf{\color{#d91a1a}-5.02\%}$
test_transformed 0.5367s 0.5354s 1.8679 Ops/s 1.8168 Ops/s $\color{#35bf28}+2.81\%$
test_serial 1.3236s 1.2689s 0.7881 Ops/s 0.7869 Ops/s $\color{#35bf28}+0.15\%$
test_parallel 1.1274s 1.0698s 0.9348 Ops/s 0.9468 Ops/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[True-True-True-True-True] 0.2145ms 22.0393μs 45.3735 KOps/s 46.5141 KOps/s $\color{#d91a1a}-2.45\%$
test_step_mdp_speed[True-True-True-True-False] 50.1750μs 13.1256μs 76.1868 KOps/s 76.5604 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[True-True-True-False-True] 38.0020μs 12.9457μs 77.2455 KOps/s 78.6520 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[True-True-True-False-False] 35.2660μs 7.6256μs 131.1373 KOps/s 130.4176 KOps/s $\color{#35bf28}+0.55\%$
test_step_mdp_speed[True-True-False-True-True] 60.1240μs 23.4890μs 42.5732 KOps/s 43.6484 KOps/s $\color{#d91a1a}-2.46\%$
test_step_mdp_speed[True-True-False-True-False] 55.0130μs 14.4828μs 69.0476 KOps/s 69.5291 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[True-True-False-False-True] 53.1500μs 14.3120μs 69.8713 KOps/s 71.8995 KOps/s $\color{#d91a1a}-2.82\%$
test_step_mdp_speed[True-True-False-False-False] 62.6880μs 8.9589μs 111.6207 KOps/s 111.0011 KOps/s $\color{#35bf28}+0.56\%$
test_step_mdp_speed[True-False-True-True-True] 49.7930μs 24.9024μs 40.1567 KOps/s 41.3698 KOps/s $\color{#d91a1a}-2.93\%$
test_step_mdp_speed[True-False-True-True-False] 52.0870μs 15.8163μs 63.2260 KOps/s 63.7373 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[True-False-True-False-True] 41.7890μs 14.3336μs 69.7660 KOps/s 72.2888 KOps/s $\color{#d91a1a}-3.49\%$
test_step_mdp_speed[True-False-True-False-False] 50.4680μs 8.9161μs 112.1564 KOps/s 111.7412 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[True-False-False-True-True] 56.3560μs 25.9110μs 38.5937 KOps/s 39.0249 KOps/s $\color{#d91a1a}-1.10\%$
test_step_mdp_speed[True-False-False-True-False] 51.9670μs 16.8673μs 59.2862 KOps/s 59.7919 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[True-False-False-False-True] 46.5680μs 15.6347μs 63.9604 KOps/s 66.5245 KOps/s $\color{#d91a1a}-3.85\%$
test_step_mdp_speed[True-False-False-False-False] 36.7890μs 10.1928μs 98.1082 KOps/s 99.4901 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[False-True-True-True-True] 65.9540μs 24.8127μs 40.3019 KOps/s 41.0090 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[False-True-True-True-False] 46.4680μs 15.8394μs 63.1335 KOps/s 63.8723 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[False-True-True-False-True] 43.8420μs 16.6344μs 60.1166 KOps/s 61.6872 KOps/s $\color{#d91a1a}-2.55\%$
test_step_mdp_speed[False-True-True-False-False] 35.1560μs 10.3083μs 97.0095 KOps/s 99.9004 KOps/s $\color{#d91a1a}-2.89\%$
test_step_mdp_speed[False-True-False-True-True] 56.8470μs 26.0853μs 38.3357 KOps/s 39.5604 KOps/s $\color{#d91a1a}-3.10\%$
test_step_mdp_speed[False-True-False-True-False] 40.8870μs 17.0587μs 58.6210 KOps/s 58.6064 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[False-True-False-False-True] 48.5410μs 17.8029μs 56.1707 KOps/s 57.9697 KOps/s $\color{#d91a1a}-3.10\%$
test_step_mdp_speed[False-True-False-False-False] 39.9750μs 11.4073μs 87.6628 KOps/s 88.6704 KOps/s $\color{#d91a1a}-1.14\%$
test_step_mdp_speed[False-False-True-True-True] 66.0440μs 27.6660μs 36.1455 KOps/s 37.6851 KOps/s $\color{#d91a1a}-4.09\%$
test_step_mdp_speed[False-False-True-True-False] 45.0450μs 18.3953μs 54.3616 KOps/s 55.3853 KOps/s $\color{#d91a1a}-1.85\%$
test_step_mdp_speed[False-False-True-False-True] 55.3640μs 17.9435μs 55.7305 KOps/s 57.8078 KOps/s $\color{#d91a1a}-3.59\%$
test_step_mdp_speed[False-False-True-False-False] 37.0800μs 11.3983μs 87.7321 KOps/s 88.4616 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[False-False-False-True-True] 39.2330μs 29.1160μs 34.3453 KOps/s 35.7532 KOps/s $\color{#d91a1a}-3.94\%$
test_step_mdp_speed[False-False-False-True-False] 48.9210μs 19.6119μs 50.9894 KOps/s 52.2811 KOps/s $\color{#d91a1a}-2.47\%$
test_step_mdp_speed[False-False-False-False-True] 47.5290μs 18.8470μs 53.0587 KOps/s 54.4168 KOps/s $\color{#d91a1a}-2.50\%$
test_step_mdp_speed[False-False-False-False-False] 41.7490μs 12.5469μs 79.7007 KOps/s 79.6782 KOps/s $\color{#35bf28}+0.03\%$
test_values[generalized_advantage_estimate-True-True] 12.1579ms 9.4825ms 105.4573 Ops/s 105.7566 Ops/s $\color{#d91a1a}-0.28\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.0860ms 35.6017ms 28.0886 Ops/s 28.1498 Ops/s $\color{#d91a1a}-0.22\%$
test_values[td0_return_estimate-False-False] 0.2481ms 0.1865ms 5.3621 KOps/s 5.9270 KOps/s $\textbf{\color{#d91a1a}-9.53\%}$
test_values[td1_return_estimate-False-False] 24.3888ms 23.6215ms 42.3344 Ops/s 42.3225 Ops/s $\color{#35bf28}+0.03\%$
test_values[vec_td1_return_estimate-False-False] 37.8013ms 35.3193ms 28.3132 Ops/s 28.0824 Ops/s $\color{#35bf28}+0.82\%$
test_values[td_lambda_return_estimate-True-False] 34.5124ms 34.0020ms 29.4101 Ops/s 28.6972 Ops/s $\color{#35bf28}+2.48\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.6603ms 35.3611ms 28.2796 Ops/s 27.9279 Ops/s $\color{#35bf28}+1.26\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.7165ms 8.3112ms 120.3201 Ops/s 120.4858 Ops/s $\color{#d91a1a}-0.14\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.0465ms 1.8770ms 532.7740 Ops/s 496.9469 Ops/s $\textbf{\color{#35bf28}+7.21\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4297ms 0.3522ms 2.8394 KOps/s 2.8269 KOps/s $\color{#35bf28}+0.44\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 45.5803ms 43.8062ms 22.8278 Ops/s 21.1468 Ops/s $\textbf{\color{#35bf28}+7.95\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.5690ms 3.0190ms 331.2367 Ops/s 325.9749 Ops/s $\color{#35bf28}+1.61\%$
test_dqn_speed 1.5862ms 1.3711ms 729.3664 Ops/s 722.7423 Ops/s $\color{#35bf28}+0.92\%$
test_ddpg_speed 3.7611ms 2.9135ms 343.2325 Ops/s 342.6423 Ops/s $\color{#35bf28}+0.17\%$
test_sac_speed 10.5816ms 8.6038ms 116.2271 Ops/s 116.0093 Ops/s $\color{#35bf28}+0.19\%$
test_redq_speed 15.5738ms 13.6609ms 73.2015 Ops/s 73.0327 Ops/s $\color{#35bf28}+0.23\%$
test_redq_deprec_speed 14.0712ms 13.3911ms 74.6766 Ops/s 71.3647 Ops/s $\color{#35bf28}+4.64\%$
test_td3_speed 16.6835ms 8.5660ms 116.7403 Ops/s 117.9784 Ops/s $\color{#d91a1a}-1.05\%$
test_cql_speed 39.4810ms 37.0954ms 26.9575 Ops/s 27.2832 Ops/s $\color{#d91a1a}-1.19\%$
test_a2c_speed 8.7455ms 7.5478ms 132.4882 Ops/s 134.7382 Ops/s $\color{#d91a1a}-1.67\%$
test_ppo_speed 10.6864ms 8.0260ms 124.5954 Ops/s 130.3090 Ops/s $\color{#d91a1a}-4.38\%$
test_reinforce_speed 7.4594ms 6.6460ms 150.4666 Ops/s 150.3745 Ops/s $\color{#35bf28}+0.06\%$
test_iql_speed 34.3403ms 32.7771ms 30.5091 Ops/s 30.5102 Ops/s $-0.00\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.8196ms 3.4332ms 291.2708 Ops/s 291.1457 Ops/s $\color{#35bf28}+0.04\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0466ms 0.4992ms 2.0032 KOps/s 1.7491 KOps/s $\textbf{\color{#35bf28}+14.53\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6446ms 0.4721ms 2.1184 KOps/s 2.1187 KOps/s $\color{#d91a1a}-0.02\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.3064ms 3.4389ms 290.7875 Ops/s 294.8856 Ops/s $\color{#d91a1a}-1.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1625ms 0.4940ms 2.0243 KOps/s 2.0361 KOps/s $\color{#d91a1a}-0.58\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6287ms 0.4663ms 2.1444 KOps/s 2.1455 KOps/s $\color{#d91a1a}-0.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7341ms 1.2505ms 799.6622 Ops/s 802.8497 Ops/s $\color{#d91a1a}-0.40\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 4.2258ms 1.1837ms 844.7775 Ops/s 851.6046 Ops/s $\color{#d91a1a}-0.80\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.3864ms 3.5789ms 279.4147 Ops/s 282.7888 Ops/s $\color{#d91a1a}-1.19\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1869ms 0.6148ms 1.6267 KOps/s 1.6362 KOps/s $\color{#d91a1a}-0.58\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7449ms 0.5869ms 1.7039 KOps/s 1.7037 KOps/s $\color{#35bf28}+0.01\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7587ms 3.5167ms 284.3588 Ops/s 291.7711 Ops/s $\color{#d91a1a}-2.54\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0910ms 0.5027ms 1.9892 KOps/s 1.9839 KOps/s $\color{#35bf28}+0.27\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6268ms 0.4777ms 2.0935 KOps/s 2.0991 KOps/s $\color{#d91a1a}-0.27\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.2723ms 3.4660ms 288.5164 Ops/s 277.0797 Ops/s $\color{#35bf28}+4.13\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.5831ms 0.4925ms 2.0303 KOps/s 2.0164 KOps/s $\color{#35bf28}+0.69\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.6809ms 0.4744ms 2.1080 KOps/s 2.1125 KOps/s $\color{#d91a1a}-0.21\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.3259ms 3.7014ms 270.1665 Ops/s 277.5095 Ops/s $\color{#d91a1a}-2.65\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7005ms 0.6145ms 1.6273 KOps/s 1.6151 KOps/s $\color{#35bf28}+0.76\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8284ms 0.5922ms 1.6886 KOps/s 1.6653 KOps/s $\color{#35bf28}+1.40\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1050s 5.6746ms 176.2243 Ops/s 119.5963 Ops/s $\textbf{\color{#35bf28}+47.35\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1059s 14.3065ms 69.8984 Ops/s 79.0503 Ops/s $\textbf{\color{#d91a1a}-11.58\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.5486ms 1.0576ms 945.5298 Ops/s 940.9919 Ops/s $\color{#35bf28}+0.48\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 97.9665ms 5.5775ms 179.2917 Ops/s 173.7697 Ops/s $\color{#35bf28}+3.18\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.2192ms 12.3795ms 80.7785 Ops/s 79.4294 Ops/s $\color{#35bf28}+1.70\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.1296ms 1.0374ms 963.9401 Ops/s 944.3404 Ops/s $\color{#35bf28}+2.08\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1107s 6.1163ms 163.4974 Ops/s 121.8874 Ops/s $\textbf{\color{#35bf28}+34.14\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1090s 14.7167ms 67.9502 Ops/s 76.9366 Ops/s $\textbf{\color{#d91a1a}-11.68\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.0631ms 1.3714ms 729.1947 Ops/s 700.8307 Ops/s $\color{#35bf28}+4.05\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}17$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1202s 0.1181s 8.4663 Ops/s 8.3018 Ops/s $\color{#35bf28}+1.98\%$
test_sync 0.1046s 0.1027s 9.7405 Ops/s 9.7127 Ops/s $\color{#35bf28}+0.29\%$
test_async 0.1982s 99.7825ms 10.0218 Ops/s 10.1823 Ops/s $\color{#d91a1a}-1.58\%$
test_single_pixels 0.1306s 0.1293s 7.7319 Ops/s 7.8023 Ops/s $\color{#d91a1a}-0.90\%$
test_sync_pixels 85.2359ms 82.1355ms 12.1750 Ops/s 11.9864 Ops/s $\color{#35bf28}+1.57\%$
test_async_pixels 0.1601s 69.6887ms 14.3495 Ops/s 14.3479 Ops/s $\color{#35bf28}+0.01\%$
test_simple 0.8877s 0.8353s 1.1971 Ops/s 1.2204 Ops/s $\color{#d91a1a}-1.91\%$
test_transformed 1.1664s 1.0982s 0.9106 Ops/s 0.9147 Ops/s $\color{#d91a1a}-0.45\%$
test_serial 2.5474s 2.4985s 0.4002 Ops/s 0.3937 Ops/s $\color{#35bf28}+1.65\%$
test_parallel 2.4209s 2.3588s 0.4239 Ops/s 0.4248 Ops/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[True-True-True-True-True] 64.8510μs 33.7796μs 29.6037 KOps/s 28.6898 KOps/s $\color{#35bf28}+3.19\%$
test_step_mdp_speed[True-True-True-True-False] 47.5010μs 20.1553μs 49.6149 KOps/s 47.6477 KOps/s $\color{#35bf28}+4.13\%$
test_step_mdp_speed[True-True-True-False-True] 37.9410μs 19.1709μs 52.1623 KOps/s 50.4437 KOps/s $\color{#35bf28}+3.41\%$
test_step_mdp_speed[True-True-True-False-False] 28.9700μs 11.3230μs 88.3154 KOps/s 85.9961 KOps/s $\color{#35bf28}+2.70\%$
test_step_mdp_speed[True-True-False-True-True] 66.5810μs 36.2817μs 27.5621 KOps/s 27.5473 KOps/s $\color{#35bf28}+0.05\%$
test_step_mdp_speed[True-True-False-True-False] 46.0310μs 21.9743μs 45.5077 KOps/s 42.7788 KOps/s $\textbf{\color{#35bf28}+6.38\%}$
test_step_mdp_speed[True-True-False-False-True] 47.0110μs 21.0374μs 47.5343 KOps/s 45.2344 KOps/s $\textbf{\color{#35bf28}+5.08\%}$
test_step_mdp_speed[True-True-False-False-False] 34.9200μs 13.2807μs 75.2975 KOps/s 69.4228 KOps/s $\textbf{\color{#35bf28}+8.46\%}$
test_step_mdp_speed[True-False-True-True-True] 63.7010μs 37.9819μs 26.3283 KOps/s 25.3589 KOps/s $\color{#35bf28}+3.82\%$
test_step_mdp_speed[True-False-True-True-False] 50.6700μs 24.1489μs 41.4098 KOps/s 38.4931 KOps/s $\textbf{\color{#35bf28}+7.58\%}$
test_step_mdp_speed[True-False-True-False-True] 46.8020μs 21.3191μs 46.9064 KOps/s 46.2780 KOps/s $\color{#35bf28}+1.36\%$
test_step_mdp_speed[True-False-True-False-False] 33.4210μs 13.2724μs 75.3443 KOps/s 69.5842 KOps/s $\textbf{\color{#35bf28}+8.28\%}$
test_step_mdp_speed[True-False-False-True-True] 70.4410μs 39.2845μs 25.4553 KOps/s 24.6670 KOps/s $\color{#35bf28}+3.20\%$
test_step_mdp_speed[True-False-False-True-False] 47.7300μs 25.7854μs 38.7816 KOps/s 36.8778 KOps/s $\textbf{\color{#35bf28}+5.16\%}$
test_step_mdp_speed[True-False-False-False-True] 46.5800μs 22.8155μs 43.8298 KOps/s 42.5121 KOps/s $\color{#35bf28}+3.10\%$
test_step_mdp_speed[True-False-False-False-False] 34.8920μs 15.0770μs 66.3261 KOps/s 63.9509 KOps/s $\color{#35bf28}+3.71\%$
test_step_mdp_speed[False-True-True-True-True] 64.5910μs 37.9287μs 26.3653 KOps/s 25.8025 KOps/s $\color{#35bf28}+2.18\%$
test_step_mdp_speed[False-True-True-True-False] 51.7310μs 24.1713μs 41.3713 KOps/s 39.0479 KOps/s $\textbf{\color{#35bf28}+5.95\%}$
test_step_mdp_speed[False-True-True-False-True] 40.1000μs 25.0454μs 39.9274 KOps/s 38.5883 KOps/s $\color{#35bf28}+3.47\%$
test_step_mdp_speed[False-True-True-False-False] 36.5300μs 15.2001μs 65.7889 KOps/s 64.0606 KOps/s $\color{#35bf28}+2.70\%$
test_step_mdp_speed[False-True-False-True-True] 72.0710μs 40.0172μs 24.9893 KOps/s 24.6759 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[False-True-False-True-False] 46.8310μs 26.3131μs 38.0039 KOps/s 37.3681 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[False-True-False-False-True] 52.7910μs 26.9375μs 37.1230 KOps/s 36.2114 KOps/s $\color{#35bf28}+2.52\%$
test_step_mdp_speed[False-True-False-False-False] 36.3010μs 17.2229μs 58.0623 KOps/s 56.1759 KOps/s $\color{#35bf28}+3.36\%$
test_step_mdp_speed[False-False-True-True-True] 60.4410μs 41.9028μs 23.8647 KOps/s 23.4231 KOps/s $\color{#35bf28}+1.89\%$
test_step_mdp_speed[False-False-True-True-False] 48.3510μs 28.1368μs 35.5406 KOps/s 34.3416 KOps/s $\color{#35bf28}+3.49\%$
test_step_mdp_speed[False-False-True-False-True] 50.5510μs 27.2992μs 36.6311 KOps/s 35.9481 KOps/s $\color{#35bf28}+1.90\%$
test_step_mdp_speed[False-False-True-False-False] 37.1300μs 17.0756μs 58.5632 KOps/s 56.4688 KOps/s $\color{#35bf28}+3.71\%$
test_step_mdp_speed[False-False-False-True-True] 71.2310μs 43.7074μs 22.8794 KOps/s 22.4491 KOps/s $\color{#35bf28}+1.92\%$
test_step_mdp_speed[False-False-False-True-False] 57.2810μs 29.8394μs 33.5127 KOps/s 32.2631 KOps/s $\color{#35bf28}+3.87\%$
test_step_mdp_speed[False-False-False-False-True] 50.0310μs 28.7167μs 34.8229 KOps/s 33.9710 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[False-False-False-False-False] 39.8210μs 18.8630μs 53.0137 KOps/s 50.4628 KOps/s $\textbf{\color{#35bf28}+5.06\%}$
test_values[generalized_advantage_estimate-True-True] 24.8611ms 24.5132ms 40.7944 Ops/s 37.8263 Ops/s $\textbf{\color{#35bf28}+7.85\%}$
test_values[vec_generalized_advantage_estimate-True-True] 87.0550ms 3.3087ms 302.2294 Ops/s 301.4765 Ops/s $\color{#35bf28}+0.25\%$
test_values[td0_return_estimate-False-False] 91.8020μs 64.3337μs 15.5440 KOps/s 15.4682 KOps/s $\color{#35bf28}+0.49\%$
test_values[td1_return_estimate-False-False] 52.7268ms 52.3387ms 19.1063 Ops/s 17.7718 Ops/s $\textbf{\color{#35bf28}+7.51\%}$
test_values[vec_td1_return_estimate-False-False] 2.1188ms 1.7681ms 565.5751 Ops/s 563.0851 Ops/s $\color{#35bf28}+0.44\%$
test_values[td_lambda_return_estimate-True-False] 85.1942ms 83.4459ms 11.9838 Ops/s 11.1382 Ops/s $\textbf{\color{#35bf28}+7.59\%}$
test_values[vec_td_lambda_return_estimate-True-False] 2.0569ms 1.7607ms 567.9532 Ops/s 565.8135 Ops/s $\color{#35bf28}+0.38\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.5484ms 23.4233ms 42.6925 Ops/s 38.8849 Ops/s $\textbf{\color{#35bf28}+9.79\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9110ms 0.6948ms 1.4393 KOps/s 1.3427 KOps/s $\textbf{\color{#35bf28}+7.19\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7083ms 0.6509ms 1.5364 KOps/s 1.4646 KOps/s $\color{#35bf28}+4.90\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4801ms 1.4495ms 689.8699 Ops/s 687.5117 Ops/s $\color{#35bf28}+0.34\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9379ms 0.6674ms 1.4982 KOps/s 1.4791 KOps/s $\color{#35bf28}+1.29\%$
test_dqn_speed 1.8302ms 1.4663ms 681.9924 Ops/s 692.9366 Ops/s $\color{#d91a1a}-1.58\%$
test_ddpg_speed 3.3362ms 2.9551ms 338.3966 Ops/s 342.3455 Ops/s $\color{#d91a1a}-1.15\%$
test_sac_speed 8.8361ms 8.4628ms 118.1635 Ops/s 119.0014 Ops/s $\color{#d91a1a}-0.70\%$
test_redq_speed 11.4908ms 10.4958ms 95.2760 Ops/s 86.9545 Ops/s $\textbf{\color{#35bf28}+9.57\%}$
test_redq_deprec_speed 12.3986ms 11.7857ms 84.8489 Ops/s 84.7679 Ops/s $\color{#35bf28}+0.10\%$
test_td3_speed 17.5005ms 8.4812ms 117.9073 Ops/s 119.8133 Ops/s $\color{#d91a1a}-1.59\%$
test_cql_speed 26.3249ms 25.7810ms 38.7883 Ops/s 38.8099 Ops/s $\color{#d91a1a}-0.06\%$
test_a2c_speed 6.1408ms 5.8133ms 172.0180 Ops/s 178.9702 Ops/s $\color{#d91a1a}-3.88\%$
test_ppo_speed 6.7380ms 6.1203ms 163.3899 Ops/s 168.0234 Ops/s $\color{#d91a1a}-2.76\%$
test_reinforce_speed 5.0067ms 4.7543ms 210.3342 Ops/s 215.3225 Ops/s $\color{#d91a1a}-2.32\%$
test_iql_speed 20.7907ms 19.8348ms 50.4166 Ops/s 50.1619 Ops/s $\color{#35bf28}+0.51\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.7844ms 4.6561ms 214.7707 Ops/s 212.3523 Ops/s $\color{#35bf28}+1.14\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.7654ms 0.5965ms 1.6765 KOps/s 1.6810 KOps/s $\color{#d91a1a}-0.27\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7734ms 0.5722ms 1.7476 KOps/s 1.7669 KOps/s $\color{#d91a1a}-1.09\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.8465ms 4.6215ms 216.3792 Ops/s 213.7377 Ops/s $\color{#35bf28}+1.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.6375ms 0.5899ms 1.6951 KOps/s 1.6964 KOps/s $\color{#d91a1a}-0.07\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7062ms 0.5681ms 1.7602 KOps/s 1.7662 KOps/s $\color{#d91a1a}-0.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6798ms 1.5599ms 641.0829 Ops/s 648.9926 Ops/s $\color{#d91a1a}-1.22\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6238ms 1.4725ms 679.1288 Ops/s 682.1119 Ops/s $\color{#d91a1a}-0.44\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8723ms 4.7422ms 210.8727 Ops/s 207.9564 Ops/s $\color{#35bf28}+1.40\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8295ms 0.7156ms 1.3974 KOps/s 1.3481 KOps/s $\color{#35bf28}+3.65\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 77.2804ms 0.7684ms 1.3015 KOps/s 1.4116 KOps/s $\textbf{\color{#d91a1a}-7.80\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.7521ms 4.6702ms 214.1240 Ops/s 212.8729 Ops/s $\color{#35bf28}+0.59\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7333ms 0.6014ms 1.6629 KOps/s 1.6575 KOps/s $\color{#35bf28}+0.32\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.5081ms 0.5783ms 1.7292 KOps/s 1.7449 KOps/s $\color{#d91a1a}-0.90\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.8763ms 4.6537ms 214.8810 Ops/s 216.4990 Ops/s $\color{#d91a1a}-0.75\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.6073ms 0.5917ms 1.6900 KOps/s 1.6771 KOps/s $\color{#35bf28}+0.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6817ms 0.5633ms 1.7752 KOps/s 1.7173 KOps/s $\color{#35bf28}+3.37\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8540ms 4.8065ms 208.0512 Ops/s 206.8791 Ops/s $\color{#35bf28}+0.57\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8407ms 0.7314ms 1.3672 KOps/s 1.3545 KOps/s $\color{#35bf28}+0.93\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.6102ms 0.7115ms 1.4055 KOps/s 1.4101 KOps/s $\color{#d91a1a}-0.33\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1263s 7.3653ms 135.7723 Ops/s 101.6806 Ops/s $\textbf{\color{#35bf28}+33.53\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 19.7430ms 15.7609ms 63.4481 Ops/s 62.3395 Ops/s $\color{#35bf28}+1.78\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.3498ms 1.3263ms 753.9659 Ops/s 787.8871 Ops/s $\color{#d91a1a}-4.31\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1176s 7.2329ms 138.2579 Ops/s 139.8442 Ops/s $\color{#d91a1a}-1.13\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1311s 18.1534ms 55.0861 Ops/s 62.4920 Ops/s $\textbf{\color{#d91a1a}-11.85\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.3554ms 1.3015ms 768.3633 Ops/s 711.6820 Ops/s $\textbf{\color{#35bf28}+7.96\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1169s 7.5392ms 132.6408 Ops/s 131.8386 Ops/s $\color{#35bf28}+0.61\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.4884ms 15.8606ms 63.0493 Ops/s 62.2738 Ops/s $\color{#35bf28}+1.25\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.7200ms 1.6597ms 602.5256 Ops/s 556.9948 Ops/s $\textbf{\color{#35bf28}+8.17\%}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmoens @facebook-github-bot