Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Ray collector on Python > 3.8 #2015

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

albertbou92
Copy link
Contributor

@albertbou92 albertbou92 commented Mar 18, 2024

Description

This PR should fix the issues with Ray and Python > 3.8

Ray uses the inspect module it its process to convert a class into a remote object to inspect the methods. If the class has methods ( in particular getitems_) that return a GenericAlias object, the inspect.signature(...) will throw an error. It is explained very well here: ray-project/ray#43117.

Therefore, I assume the long term fix should come from the inspect module.

However, since at least for our collectors the only problematic methods was indeed _getitems__, we can just declared it and not return a GenericAlias object.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Copy link

pytorch-bot bot commented Mar 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2015

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Unrelated Failures

As of commit 15766ab with merge base e3b66bb (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2024
@vmoens vmoens changed the title [BigFix] Fix Ray collector on Python > 3.8 [BugFix] Fix Ray collector on Python > 3.8 Mar 18, 2024
@vmoens
Copy link
Contributor

vmoens commented Mar 18, 2024

image
Indeed this is a big fix! Thanks for this

@vmoens vmoens added the bug Something isn't working label Mar 18, 2024
@vmoens vmoens merged commit 87f3437 into pytorch:main Mar 18, 2024
61 of 67 checks passed
SandishKumarHN pushed a commit to SandishKumarHN/rl that referenced this pull request Mar 18, 2024
vmoens pushed a commit that referenced this pull request Mar 25, 2024
vmoens pushed a commit that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants