[BugFix] Fix Ray collector on Python > 3.8 #2015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should fix the issues with Ray and Python > 3.8
Ray uses the
inspect
module it its process to convert a class into a remote object to inspect the methods. If the class has methods ( in particular getitems_) that return a GenericAlias object, the inspect.signature(...) will throw an error. It is explained very well here: ray-project/ray#43117.Therefore, I assume the long term fix should come from the
inspect
module.However, since at least for our collectors the only problematic methods was indeed
_getitems__
, we can just declared it and not return a GenericAlias object.Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!