Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix examples #1945

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[BugFix] Fix examples #1945

merged 1 commit into from
Feb 21, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 21, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1945

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0ac1f3b with merge base 23bf315 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2024
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 61.5769ms 61.1012ms 16.3663 Ops/s 15.6098 Ops/s $\color{#35bf28}+4.85\%$
test_sync 35.6903ms 33.4492ms 29.8961 Ops/s 27.6599 Ops/s $\textbf{\color{#35bf28}+8.08\%}$
test_async 64.0193ms 30.7240ms 32.5479 Ops/s 31.4943 Ops/s $\color{#35bf28}+3.35\%$
test_simple 0.4948s 0.4386s 2.2799 Ops/s 2.2736 Ops/s $\color{#35bf28}+0.28\%$
test_transformed 0.6445s 0.5969s 1.6752 Ops/s 1.7050 Ops/s $\color{#d91a1a}-1.75\%$
test_serial 1.4928s 1.4337s 0.6975 Ops/s 0.6955 Ops/s $\color{#35bf28}+0.29\%$
test_parallel 1.5013s 1.4355s 0.6966 Ops/s 0.7108 Ops/s $\color{#d91a1a}-1.99\%$
test_step_mdp_speed[True-True-True-True-True] 0.1421ms 21.1528μs 47.2751 KOps/s 46.9725 KOps/s $\color{#35bf28}+0.64\%$
test_step_mdp_speed[True-True-True-True-False] 39.4540μs 12.8376μs 77.8964 KOps/s 76.2763 KOps/s $\color{#35bf28}+2.12\%$
test_step_mdp_speed[True-True-True-False-True] 37.1600μs 12.3313μs 81.0945 KOps/s 80.4140 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[True-True-True-False-False] 30.0460μs 7.4661μs 133.9396 KOps/s 133.4166 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[True-True-False-True-True] 67.4670μs 22.4091μs 44.6247 KOps/s 44.8598 KOps/s $\color{#d91a1a}-0.52\%$
test_step_mdp_speed[True-True-False-True-False] 39.1530μs 14.1429μs 70.7069 KOps/s 70.6442 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-False-False-True] 42.7700μs 13.6565μs 73.2251 KOps/s 73.2883 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[True-True-False-False-False] 34.6860μs 8.7091μs 114.8227 KOps/s 113.1387 KOps/s $\color{#35bf28}+1.49\%$
test_step_mdp_speed[True-False-True-True-True] 53.4800μs 23.7338μs 42.1340 KOps/s 41.8761 KOps/s $\color{#35bf28}+0.62\%$
test_step_mdp_speed[True-False-True-True-False] 43.0910μs 15.3050μs 65.3381 KOps/s 64.2785 KOps/s $\color{#35bf28}+1.65\%$
test_step_mdp_speed[True-False-True-False-True] 38.1520μs 13.4803μs 74.1826 KOps/s 72.8431 KOps/s $\color{#35bf28}+1.84\%$
test_step_mdp_speed[True-False-True-False-False] 33.4430μs 8.5707μs 116.6769 KOps/s 113.8833 KOps/s $\color{#35bf28}+2.45\%$
test_step_mdp_speed[True-False-False-True-True] 69.4310μs 24.9306μs 40.1114 KOps/s 39.9515 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[True-False-False-True-False] 49.8140μs 16.4975μs 60.6154 KOps/s 59.9082 KOps/s $\color{#35bf28}+1.18\%$
test_step_mdp_speed[True-False-False-False-True] 40.0850μs 14.6265μs 68.3689 KOps/s 68.4918 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-False-False-False-False] 40.3260μs 9.8484μs 101.5396 KOps/s 100.0099 KOps/s $\color{#35bf28}+1.53\%$
test_step_mdp_speed[False-True-True-True-True] 65.5030μs 23.8326μs 41.9593 KOps/s 41.9055 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[False-True-True-True-False] 46.3370μs 15.3299μs 65.2319 KOps/s 64.3028 KOps/s $\color{#35bf28}+1.44\%$
test_step_mdp_speed[False-True-True-False-True] 62.0050μs 16.0122μs 62.4523 KOps/s 63.0274 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[False-True-True-False-False] 38.6230μs 9.8671μs 101.3466 KOps/s 100.3183 KOps/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[False-True-False-True-True] 35.6670μs 25.1489μs 39.7631 KOps/s 39.4013 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-True-False-True-False] 38.5220μs 16.5170μs 60.5435 KOps/s 59.9500 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[False-True-False-False-True] 47.8900μs 17.1895μs 58.1751 KOps/s 58.6203 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[False-True-False-False-False] 41.2980μs 11.1262μs 89.8780 KOps/s 88.9764 KOps/s $\color{#35bf28}+1.01\%$
test_step_mdp_speed[False-False-True-True-True] 74.0290μs 26.4081μs 37.8672 KOps/s 37.6033 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[False-False-True-True-False] 50.1750μs 18.0315μs 55.4584 KOps/s 55.5908 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[False-False-True-False-True] 42.3700μs 17.1438μs 58.3300 KOps/s 58.3985 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[False-False-True-False-False] 34.3650μs 11.0334μs 90.6336 KOps/s 89.5600 KOps/s $\color{#35bf28}+1.20\%$
test_step_mdp_speed[False-False-False-True-True] 70.1810μs 27.1245μs 36.8670 KOps/s 36.5685 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[False-False-False-True-False] 46.4670μs 18.6849μs 53.5191 KOps/s 52.6393 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[False-False-False-False-True] 44.2930μs 17.9514μs 55.7059 KOps/s 55.4459 KOps/s $\color{#35bf28}+0.47\%$
test_step_mdp_speed[False-False-False-False-False] 41.7880μs 12.1699μs 82.1701 KOps/s 82.8287 KOps/s $\color{#d91a1a}-0.80\%$
test_values[generalized_advantage_estimate-True-True] 9.5558ms 9.1827ms 108.8999 Ops/s 109.6460 Ops/s $\color{#d91a1a}-0.68\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.4015ms 33.5471ms 29.8088 Ops/s 28.3540 Ops/s $\textbf{\color{#35bf28}+5.13\%}$
test_values[td0_return_estimate-False-False] 0.2257ms 0.1647ms 6.0726 KOps/s 5.9483 KOps/s $\color{#35bf28}+2.09\%$
test_values[td1_return_estimate-False-False] 23.3731ms 22.8712ms 43.7231 Ops/s 43.4218 Ops/s $\color{#35bf28}+0.69\%$
test_values[vec_td1_return_estimate-False-False] 34.6947ms 33.4809ms 29.8678 Ops/s 28.2964 Ops/s $\textbf{\color{#35bf28}+5.55\%}$
test_values[td_lambda_return_estimate-True-False] 42.4219ms 33.4666ms 29.8805 Ops/s 29.9593 Ops/s $\color{#d91a1a}-0.26\%$
test_values[vec_td_lambda_return_estimate-True-False] 34.9782ms 33.5300ms 29.8241 Ops/s 28.2533 Ops/s $\textbf{\color{#35bf28}+5.56\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.2894ms 8.1449ms 122.7767 Ops/s 123.1323 Ops/s $\color{#d91a1a}-0.29\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2897ms 2.0094ms 497.6550 Ops/s 531.4541 Ops/s $\textbf{\color{#d91a1a}-6.36\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4395ms 0.3474ms 2.8787 KOps/s 2.8822 KOps/s $\color{#d91a1a}-0.12\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 56.0424ms 45.3115ms 22.0694 Ops/s 20.9981 Ops/s $\textbf{\color{#35bf28}+5.10\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.5130ms 3.0171ms 331.4426 Ops/s 329.4380 Ops/s $\color{#35bf28}+0.61\%$
test_dqn_speed 69.3521ms 1.5002ms 666.5842 Ops/s 718.5350 Ops/s $\textbf{\color{#d91a1a}-7.23\%}$
test_ddpg_speed 3.3403ms 2.7891ms 358.5408 Ops/s 358.7293 Ops/s $\color{#d91a1a}-0.05\%$
test_sac_speed 8.7589ms 8.3405ms 119.8973 Ops/s 119.7337 Ops/s $\color{#35bf28}+0.14\%$
test_redq_speed 16.9458ms 13.3512ms 74.8998 Ops/s 74.6559 Ops/s $\color{#35bf28}+0.33\%$
test_redq_deprec_speed 14.0822ms 13.1793ms 75.8766 Ops/s 74.3262 Ops/s $\color{#35bf28}+2.09\%$
test_td3_speed 8.5621ms 8.3412ms 119.8872 Ops/s 120.2587 Ops/s $\color{#d91a1a}-0.31\%$
test_cql_speed 37.6342ms 36.4332ms 27.4475 Ops/s 27.3179 Ops/s $\color{#35bf28}+0.47\%$
test_a2c_speed 8.7567ms 7.4533ms 134.1687 Ops/s 134.8777 Ops/s $\color{#d91a1a}-0.53\%$
test_ppo_speed 8.3979ms 7.6933ms 129.9827 Ops/s 130.9515 Ops/s $\color{#d91a1a}-0.74\%$
test_reinforce_speed 7.6331ms 6.6230ms 150.9895 Ops/s 151.5040 Ops/s $\color{#d91a1a}-0.34\%$
test_iql_speed 34.2821ms 32.8186ms 30.4705 Ops/s 30.5678 Ops/s $\color{#d91a1a}-0.32\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.2404ms 2.8544ms 350.3319 Ops/s 345.2956 Ops/s $\color{#35bf28}+1.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6206ms 0.5168ms 1.9350 KOps/s 1.9460 KOps/s $\color{#d91a1a}-0.56\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7607ms 0.4922ms 2.0318 KOps/s 2.0512 KOps/s $\color{#d91a1a}-0.94\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2137ms 2.9029ms 344.4805 Ops/s 343.7303 Ops/s $\color{#35bf28}+0.22\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7850ms 0.5154ms 1.9403 KOps/s 1.9613 KOps/s $\color{#d91a1a}-1.07\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7586ms 0.4890ms 2.0449 KOps/s 2.0854 KOps/s $\color{#d91a1a}-1.94\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2624ms 2.9976ms 333.6057 Ops/s 331.2760 Ops/s $\color{#35bf28}+0.70\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8898ms 0.6373ms 1.5690 KOps/s 1.5943 KOps/s $\color{#d91a1a}-1.59\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9264ms 0.6091ms 1.6417 KOps/s 1.6658 KOps/s $\color{#d91a1a}-1.45\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.1499ms 2.8621ms 349.3968 Ops/s 349.8292 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9799ms 0.5234ms 1.9107 KOps/s 1.8721 KOps/s $\color{#35bf28}+2.06\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8686ms 0.4962ms 2.0155 KOps/s 2.0519 KOps/s $\color{#d91a1a}-1.77\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2718ms 2.9108ms 343.5446 Ops/s 339.0012 Ops/s $\color{#35bf28}+1.34\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6628ms 0.5118ms 1.9539 KOps/s 1.9504 KOps/s $\color{#35bf28}+0.18\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6043ms 0.4835ms 2.0683 KOps/s 2.0576 KOps/s $\color{#35bf28}+0.52\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2750ms 2.9789ms 335.6946 Ops/s 339.9553 Ops/s $\color{#d91a1a}-1.25\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8145ms 0.6361ms 1.5720 KOps/s 1.5793 KOps/s $\color{#d91a1a}-0.47\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9893ms 0.6143ms 1.6278 KOps/s 1.6568 KOps/s $\color{#d91a1a}-1.75\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1151s 8.1397ms 122.8542 Ops/s 126.2536 Ops/s $\color{#d91a1a}-2.69\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.3411ms 13.0687ms 76.5187 Ops/s 67.6079 Ops/s $\textbf{\color{#35bf28}+13.18\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.9513ms 2.5267ms 395.7800 Ops/s 397.6173 Ops/s $\color{#d91a1a}-0.46\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1012s 9.7410ms 102.6593 Ops/s 128.5592 Ops/s $\textbf{\color{#d91a1a}-20.15\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.2199ms 13.1655ms 75.9563 Ops/s 76.4759 Ops/s $\color{#d91a1a}-0.68\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.0567ms 2.5451ms 392.9173 Ops/s 356.8699 Ops/s $\textbf{\color{#35bf28}+10.10\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 94.1279ms 9.7200ms 102.8807 Ops/s 101.0112 Ops/s $\color{#35bf28}+1.85\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.8570ms 13.3519ms 74.8959 Ops/s 75.5311 Ops/s $\color{#d91a1a}-0.84\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.7663ms 2.8534ms 350.4537 Ops/s 357.2039 Ops/s $\color{#d91a1a}-1.89\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1163s 0.1153s 8.6750 Ops/s 8.2383 Ops/s $\textbf{\color{#35bf28}+5.30\%}$
test_sync 95.7300ms 95.4510ms 10.4766 Ops/s 10.4605 Ops/s $\color{#35bf28}+0.15\%$
test_async 0.1810s 91.6354ms 10.9128 Ops/s 10.9340 Ops/s $\color{#d91a1a}-0.19\%$
test_single_pixels 0.2068s 0.1462s 6.8413 Ops/s 7.0968 Ops/s $\color{#d91a1a}-3.60\%$
test_sync_pixels 82.6132ms 81.7170ms 12.2374 Ops/s 12.2069 Ops/s $\color{#35bf28}+0.25\%$
test_async_pixels 0.1406s 67.0396ms 14.9165 Ops/s 14.5997 Ops/s $\color{#35bf28}+2.17\%$
test_simple 0.8254s 0.8232s 1.2148 Ops/s 1.1952 Ops/s $\color{#35bf28}+1.64\%$
test_transformed 1.0771s 1.0610s 0.9425 Ops/s 0.9462 Ops/s $\color{#d91a1a}-0.39\%$
test_serial 2.5257s 2.4727s 0.4044 Ops/s 0.4122 Ops/s $\color{#d91a1a}-1.88\%$
test_parallel 2.1599s 2.1141s 0.4730 Ops/s 0.4753 Ops/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-True-True-True-True] 0.1011ms 33.4333μs 29.9103 KOps/s 30.4957 KOps/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[True-True-True-True-False] 0.3078ms 20.0003μs 49.9992 KOps/s 50.8331 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-True-True-False-True] 0.2057ms 18.9717μs 52.7100 KOps/s 53.8082 KOps/s $\color{#d91a1a}-2.04\%$
test_step_mdp_speed[True-True-True-False-False] 29.2520μs 11.2554μs 88.8460 KOps/s 89.2868 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[True-True-False-True-True] 0.2376ms 35.5293μs 28.1458 KOps/s 29.1428 KOps/s $\color{#d91a1a}-3.42\%$
test_step_mdp_speed[True-True-False-True-False] 0.2179ms 21.9211μs 45.6181 KOps/s 46.6205 KOps/s $\color{#d91a1a}-2.15\%$
test_step_mdp_speed[True-True-False-False-True] 0.2082ms 20.8317μs 48.0037 KOps/s 49.1516 KOps/s $\color{#d91a1a}-2.34\%$
test_step_mdp_speed[True-True-False-False-False] 33.9110μs 13.4603μs 74.2927 KOps/s 75.3999 KOps/s $\color{#d91a1a}-1.47\%$
test_step_mdp_speed[True-False-True-True-True] 0.2266ms 37.3455μs 26.7770 KOps/s 27.2638 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[True-False-True-True-False] 0.2189ms 24.0068μs 41.6549 KOps/s 42.2274 KOps/s $\color{#d91a1a}-1.36\%$
test_step_mdp_speed[True-False-True-False-True] 41.5830μs 21.0069μs 47.6034 KOps/s 49.2431 KOps/s $\color{#d91a1a}-3.33\%$
test_step_mdp_speed[True-False-True-False-False] 0.2031ms 13.1606μs 75.9841 KOps/s 76.3476 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-False-False-True-True] 0.2570ms 38.9884μs 25.6487 KOps/s 26.3994 KOps/s $\color{#d91a1a}-2.84\%$
test_step_mdp_speed[True-False-False-True-False] 0.2396ms 25.7677μs 38.8083 KOps/s 39.7985 KOps/s $\color{#d91a1a}-2.49\%$
test_step_mdp_speed[True-False-False-False-True] 45.8030μs 22.1298μs 45.1880 KOps/s 45.5286 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-False-False-False-False] 0.2188ms 15.0179μs 66.5873 KOps/s 67.2753 KOps/s $\color{#d91a1a}-1.02\%$
test_step_mdp_speed[False-True-True-True-True] 0.2294ms 37.5704μs 26.6167 KOps/s 27.9284 KOps/s $\color{#d91a1a}-4.70\%$
test_step_mdp_speed[False-True-True-True-False] 0.2288ms 23.9503μs 41.7531 KOps/s 42.8984 KOps/s $\color{#d91a1a}-2.67\%$
test_step_mdp_speed[False-True-True-False-True] 45.0320μs 24.9553μs 40.0716 KOps/s 41.6064 KOps/s $\color{#d91a1a}-3.69\%$
test_step_mdp_speed[False-True-True-False-False] 0.2040ms 15.2593μs 65.5339 KOps/s 66.7453 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[False-True-False-True-True] 69.2530μs 39.7667μs 25.1467 KOps/s 25.9054 KOps/s $\color{#d91a1a}-2.93\%$
test_step_mdp_speed[False-True-False-True-False] 0.2344ms 25.8922μs 38.6217 KOps/s 39.4049 KOps/s $\color{#d91a1a}-1.99\%$
test_step_mdp_speed[False-True-False-False-True] 0.2366ms 26.7050μs 37.4461 KOps/s 38.5410 KOps/s $\color{#d91a1a}-2.84\%$
test_step_mdp_speed[False-True-False-False-False] 46.3920μs 17.1360μs 58.3568 KOps/s 59.7794 KOps/s $\color{#d91a1a}-2.38\%$
test_step_mdp_speed[False-False-True-True-True] 0.2421ms 40.7836μs 24.5196 KOps/s 25.0892 KOps/s $\color{#d91a1a}-2.27\%$
test_step_mdp_speed[False-False-True-True-False] 0.2212ms 27.7546μs 36.0301 KOps/s 36.7464 KOps/s $\color{#d91a1a}-1.95\%$
test_step_mdp_speed[False-False-True-False-True] 0.3301ms 26.8888μs 37.1902 KOps/s 38.6507 KOps/s $\color{#d91a1a}-3.78\%$
test_step_mdp_speed[False-False-True-False-False] 38.6720μs 16.9798μs 58.8936 KOps/s 60.4618 KOps/s $\color{#d91a1a}-2.59\%$
test_step_mdp_speed[False-False-False-True-True] 0.2285ms 42.6904μs 23.4244 KOps/s 24.0203 KOps/s $\color{#d91a1a}-2.48\%$
test_step_mdp_speed[False-False-False-True-False] 0.2324ms 29.3635μs 34.0559 KOps/s 34.3856 KOps/s $\color{#d91a1a}-0.96\%$
test_step_mdp_speed[False-False-False-False-True] 47.2720μs 28.0635μs 35.6335 KOps/s 36.5597 KOps/s $\color{#d91a1a}-2.53\%$
test_step_mdp_speed[False-False-False-False-False] 0.2067ms 18.8235μs 53.1250 KOps/s 54.5696 KOps/s $\color{#d91a1a}-2.65\%$
test_values[generalized_advantage_estimate-True-True] 25.4042ms 25.0130ms 39.9793 Ops/s 39.9940 Ops/s $\color{#d91a1a}-0.04\%$
test_values[vec_generalized_advantage_estimate-True-True] 89.7488ms 3.3628ms 297.3748 Ops/s 307.5105 Ops/s $\color{#d91a1a}-3.30\%$
test_values[td0_return_estimate-False-False] 0.1141ms 63.3515μs 15.7850 KOps/s 16.2290 KOps/s $\color{#d91a1a}-2.74\%$
test_values[td1_return_estimate-False-False] 54.8288ms 54.3324ms 18.4052 Ops/s 18.6302 Ops/s $\color{#d91a1a}-1.21\%$
test_values[vec_td1_return_estimate-False-False] 2.0696ms 1.7695ms 565.1271 Ops/s 568.1402 Ops/s $\color{#d91a1a}-0.53\%$
test_values[td_lambda_return_estimate-True-False] 95.6944ms 88.5460ms 11.2936 Ops/s 10.9113 Ops/s $\color{#35bf28}+3.50\%$
test_values[vec_td_lambda_return_estimate-True-False] 3.8882ms 1.8030ms 554.6172 Ops/s 554.9949 Ops/s $\color{#d91a1a}-0.07\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.2039ms 24.0165ms 41.6380 Ops/s 39.7605 Ops/s $\color{#35bf28}+4.72\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8824ms 0.7103ms 1.4080 KOps/s 1.4170 KOps/s $\color{#d91a1a}-0.64\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8822ms 0.6596ms 1.5162 KOps/s 1.4521 KOps/s $\color{#35bf28}+4.41\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4871ms 1.4633ms 683.3799 Ops/s 682.4365 Ops/s $\color{#35bf28}+0.14\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9751ms 0.6789ms 1.4730 KOps/s 1.4819 KOps/s $\color{#d91a1a}-0.60\%$
test_dqn_speed 4.0838ms 1.4762ms 677.3977 Ops/s 680.6257 Ops/s $\color{#d91a1a}-0.47\%$
test_ddpg_speed 5.1792ms 2.8945ms 345.4812 Ops/s 353.5783 Ops/s $\color{#d91a1a}-2.29\%$
test_sac_speed 9.7435ms 8.2483ms 121.2371 Ops/s 122.3171 Ops/s $\color{#d91a1a}-0.88\%$
test_redq_speed 11.1211ms 10.3103ms 96.9905 Ops/s 96.3692 Ops/s $\color{#35bf28}+0.64\%$
test_redq_deprec_speed 11.9775ms 11.3653ms 87.9869 Ops/s 90.1244 Ops/s $\color{#d91a1a}-2.37\%$
test_td3_speed 8.5327ms 8.2971ms 120.5246 Ops/s 121.9783 Ops/s $\color{#d91a1a}-1.19\%$
test_cql_speed 26.5987ms 25.4492ms 39.2940 Ops/s 36.0662 Ops/s $\textbf{\color{#35bf28}+8.95\%}$
test_a2c_speed 6.2619ms 5.6639ms 176.5562 Ops/s 184.7214 Ops/s $\color{#d91a1a}-4.42\%$
test_ppo_speed 6.1923ms 5.9881ms 166.9990 Ops/s 172.4543 Ops/s $\color{#d91a1a}-3.16\%$
test_reinforce_speed 5.6935ms 4.5702ms 218.8066 Ops/s 222.0893 Ops/s $\color{#d91a1a}-1.48\%$
test_iql_speed 0.1008s 20.9980ms 47.6236 Ops/s 51.6648 Ops/s $\textbf{\color{#d91a1a}-7.82\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.9420ms 3.7214ms 268.7130 Ops/s 272.7328 Ops/s $\color{#d91a1a}-1.47\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 90.6936ms 0.6354ms 1.5739 KOps/s 1.7935 KOps/s $\textbf{\color{#d91a1a}-12.25\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7753ms 0.5353ms 1.8679 KOps/s 1.8875 KOps/s $\color{#d91a1a}-1.04\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.0222ms 3.7476ms 266.8346 Ops/s 270.6679 Ops/s $\color{#d91a1a}-1.42\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6969ms 0.5613ms 1.7816 KOps/s 1.8108 KOps/s $\color{#d91a1a}-1.61\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6794ms 0.5342ms 1.8720 KOps/s 1.9051 KOps/s $\color{#d91a1a}-1.74\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.9586ms 3.8626ms 258.8898 Ops/s 260.9234 Ops/s $\color{#d91a1a}-0.78\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8568ms 0.6947ms 1.4395 KOps/s 1.3133 KOps/s $\textbf{\color{#35bf28}+9.61\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 91.9969ms 0.7475ms 1.3378 KOps/s 1.5268 KOps/s $\textbf{\color{#d91a1a}-12.38\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.9223ms 3.7160ms 269.1084 Ops/s 271.3864 Ops/s $\color{#d91a1a}-0.84\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7136ms 0.5707ms 1.7523 KOps/s 1.7887 KOps/s $\color{#d91a1a}-2.04\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6743ms 0.5442ms 1.8377 KOps/s 1.8885 KOps/s $\color{#d91a1a}-2.69\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9932ms 3.7417ms 267.2550 Ops/s 268.5840 Ops/s $\color{#d91a1a}-0.49\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6978ms 0.5665ms 1.7651 KOps/s 1.8135 KOps/s $\color{#d91a1a}-2.67\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7728ms 0.5363ms 1.8647 KOps/s 1.8837 KOps/s $\color{#d91a1a}-1.01\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.9556ms 3.8548ms 259.4158 Ops/s 260.0040 Ops/s $\color{#d91a1a}-0.23\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8210ms 0.6983ms 1.4320 KOps/s 1.4501 KOps/s $\color{#d91a1a}-1.25\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7838ms 0.6710ms 1.4902 KOps/s 1.5121 KOps/s $\color{#d91a1a}-1.45\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1032s 11.1934ms 89.3383 Ops/s 89.2110 Ops/s $\color{#35bf28}+0.14\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.9159ms 16.4830ms 60.6687 Ops/s 59.6116 Ops/s $\color{#35bf28}+1.77\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 5.6329ms 3.1041ms 322.1505 Ops/s 329.4500 Ops/s $\color{#d91a1a}-2.22\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1013s 11.1797ms 89.4477 Ops/s 89.8626 Ops/s $\color{#d91a1a}-0.46\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.9855ms 16.3965ms 60.9885 Ops/s 61.1518 Ops/s $\color{#d91a1a}-0.27\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.8724ms 3.0978ms 322.8055 Ops/s 325.2667 Ops/s $\color{#d91a1a}-0.76\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1002s 9.5607ms 104.5951 Ops/s 86.6945 Ops/s $\textbf{\color{#35bf28}+20.65\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.0813ms 16.5168ms 60.5443 Ops/s 60.1747 Ops/s $\color{#35bf28}+0.61\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 97.0489ms 5.2482ms 190.5412 Ops/s 300.2341 Ops/s $\textbf{\color{#d91a1a}-36.54\%}$

@vmoens vmoens added bug Something isn't working Suitable for minor Suitable to be integrated in minor release (no new feature) labels Feb 21, 2024
@vmoens vmoens merged commit bb44067 into main Feb 21, 2024
67 of 68 checks passed
@vmoens vmoens deleted the fix-examples branch February 21, 2024 22:11
vmoens added a commit that referenced this pull request Feb 28, 2024
@vmoens
[BugFix] Fix examples (#1945)
ad02db6
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Suitable for minor Suitable to be integrated in minor release (no new feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmoens @facebook-github-bot