Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix habitat #1941

Merged
merged 4 commits into from
Feb 20, 2024
Merged

[BugFix] Fix habitat #1941

merged 4 commits into from
Feb 20, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 20, 2024

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1941

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (25 Unrelated Failures)

As of commit 2651d6c with merge base 93885b6 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1173s 0.1172s 8.5348 Ops/s 8.3409 Ops/s $\color{#35bf28}+2.32\%$
test_sync 96.1265ms 95.3595ms 10.4866 Ops/s 10.4597 Ops/s $\color{#35bf28}+0.26\%$
test_async 0.1812s 91.6376ms 10.9125 Ops/s 10.9320 Ops/s $\color{#d91a1a}-0.18\%$
test_single_pixels 0.2093s 0.1407s 7.1054 Ops/s 7.1397 Ops/s $\color{#d91a1a}-0.48\%$
test_sync_pixels 83.5196ms 82.1536ms 12.1723 Ops/s 12.1976 Ops/s $\color{#d91a1a}-0.21\%$
test_async_pixels 0.1502s 65.4047ms 15.2894 Ops/s 14.9776 Ops/s $\color{#35bf28}+2.08\%$
test_simple 0.8357s 0.8347s 1.1981 Ops/s 1.1869 Ops/s $\color{#35bf28}+0.94\%$
test_transformed 1.0787s 1.0736s 0.9314 Ops/s 0.9444 Ops/s $\color{#d91a1a}-1.38\%$
test_serial 2.5735s 2.5166s 0.3974 Ops/s 0.4115 Ops/s $\color{#d91a1a}-3.43\%$
test_parallel 2.1375s 2.1145s 0.4729 Ops/s 0.4759 Ops/s $\color{#d91a1a}-0.63\%$
test_step_mdp_speed[True-True-True-True-True] 71.5710μs 32.7698μs 30.5159 KOps/s 30.6663 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[True-True-True-True-False] 44.1210μs 19.7192μs 50.7121 KOps/s 52.1224 KOps/s $\color{#d91a1a}-2.71\%$
test_step_mdp_speed[True-True-True-False-True] 39.8900μs 18.7684μs 53.2811 KOps/s 54.8805 KOps/s $\color{#d91a1a}-2.91\%$
test_step_mdp_speed[True-True-True-False-False] 39.4510μs 11.1635μs 89.5775 KOps/s 91.8092 KOps/s $\color{#d91a1a}-2.43\%$
test_step_mdp_speed[True-True-False-True-True] 60.2600μs 34.8396μs 28.7030 KOps/s 29.0189 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[True-True-False-True-False] 48.0510μs 21.6313μs 46.2293 KOps/s 48.2722 KOps/s $\color{#d91a1a}-4.23\%$
test_step_mdp_speed[True-True-False-False-True] 43.2600μs 20.6602μs 48.4022 KOps/s 50.5495 KOps/s $\color{#d91a1a}-4.25\%$
test_step_mdp_speed[True-True-False-False-False] 31.5210μs 12.9999μs 76.9235 KOps/s 78.3726 KOps/s $\color{#d91a1a}-1.85\%$
test_step_mdp_speed[True-False-True-True-True] 62.1400μs 36.8900μs 27.1076 KOps/s 27.7326 KOps/s $\color{#d91a1a}-2.25\%$
test_step_mdp_speed[True-False-True-True-False] 68.6610μs 23.6230μs 42.3316 KOps/s 43.5565 KOps/s $\color{#d91a1a}-2.81\%$
test_step_mdp_speed[True-False-True-False-True] 79.9610μs 20.3452μs 49.1515 KOps/s 49.7344 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[True-False-True-False-False] 30.1610μs 13.2935μs 75.2247 KOps/s 77.9525 KOps/s $\color{#d91a1a}-3.50\%$
test_step_mdp_speed[True-False-False-True-True] 63.0410μs 38.4251μs 26.0247 KOps/s 26.1391 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[True-False-False-True-False] 52.9110μs 24.9487μs 40.0823 KOps/s 40.2548 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[True-False-False-False-True] 55.1410μs 22.3550μs 44.7327 KOps/s 46.2034 KOps/s $\color{#d91a1a}-3.18\%$
test_step_mdp_speed[True-False-False-False-False] 40.9110μs 15.1892μs 65.8364 KOps/s 68.8492 KOps/s $\color{#d91a1a}-4.38\%$
test_step_mdp_speed[False-True-True-True-True] 79.9010μs 36.7523μs 27.2092 KOps/s 27.3017 KOps/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[False-True-True-True-False] 47.3110μs 23.6431μs 42.2956 KOps/s 43.2184 KOps/s $\color{#d91a1a}-2.14\%$
test_step_mdp_speed[False-True-True-False-True] 44.6010μs 24.7508μs 40.4028 KOps/s 42.0475 KOps/s $\color{#d91a1a}-3.91\%$
test_step_mdp_speed[False-True-True-False-False] 36.6100μs 14.7945μs 67.5928 KOps/s 68.7284 KOps/s $\color{#d91a1a}-1.65\%$
test_step_mdp_speed[False-True-False-True-True] 65.3110μs 38.8878μs 25.7150 KOps/s 26.2361 KOps/s $\color{#d91a1a}-1.99\%$
test_step_mdp_speed[False-True-False-True-False] 51.1010μs 25.6848μs 38.9335 KOps/s 40.0878 KOps/s $\color{#d91a1a}-2.88\%$
test_step_mdp_speed[False-True-False-False-True] 49.4800μs 26.1785μs 38.1993 KOps/s 38.6853 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[False-True-False-False-False] 38.0810μs 16.8582μs 59.3185 KOps/s 61.4145 KOps/s $\color{#d91a1a}-3.41\%$
test_step_mdp_speed[False-False-True-True-True] 69.3410μs 40.9545μs 24.4173 KOps/s 25.3071 KOps/s $\color{#d91a1a}-3.52\%$
test_step_mdp_speed[False-False-True-True-False] 54.5710μs 27.4490μs 36.4311 KOps/s 37.3838 KOps/s $\color{#d91a1a}-2.55\%$
test_step_mdp_speed[False-False-True-False-True] 55.7010μs 26.2635μs 38.0756 KOps/s 39.2095 KOps/s $\color{#d91a1a}-2.89\%$
test_step_mdp_speed[False-False-True-False-False] 38.2200μs 16.9349μs 59.0496 KOps/s 61.2125 KOps/s $\color{#d91a1a}-3.53\%$
test_step_mdp_speed[False-False-False-True-True] 66.2610μs 42.6152μs 23.4658 KOps/s 24.3000 KOps/s $\color{#d91a1a}-3.43\%$
test_step_mdp_speed[False-False-False-True-False] 53.4810μs 29.0673μs 34.4029 KOps/s 35.0761 KOps/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[False-False-False-False-True] 50.8900μs 27.9476μs 35.7813 KOps/s 36.9039 KOps/s $\color{#d91a1a}-3.04\%$
test_step_mdp_speed[False-False-False-False-False] 58.5100μs 18.6783μs 53.5380 KOps/s 55.5404 KOps/s $\color{#d91a1a}-3.61\%$
test_values[generalized_advantage_estimate-True-True] 26.1300ms 25.7043ms 38.9041 Ops/s 40.2159 Ops/s $\color{#d91a1a}-3.26\%$
test_values[vec_generalized_advantage_estimate-True-True] 84.1160ms 3.2550ms 307.2210 Ops/s 300.2071 Ops/s $\color{#35bf28}+2.34\%$
test_values[td0_return_estimate-False-False] 98.4510μs 62.4435μs 16.0145 KOps/s 16.5615 KOps/s $\color{#d91a1a}-3.30\%$
test_values[td1_return_estimate-False-False] 56.3097ms 54.8000ms 18.2482 Ops/s 18.8633 Ops/s $\color{#d91a1a}-3.26\%$
test_values[vec_td1_return_estimate-False-False] 2.0789ms 1.7772ms 562.6961 Ops/s 567.2505 Ops/s $\color{#d91a1a}-0.80\%$
test_values[td_lambda_return_estimate-True-False] 88.6143ms 87.2687ms 11.4589 Ops/s 11.7783 Ops/s $\color{#d91a1a}-2.71\%$
test_values[vec_td_lambda_return_estimate-True-False] 3.8412ms 1.8074ms 553.2745 Ops/s 532.9666 Ops/s $\color{#35bf28}+3.81\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.6165ms 24.3869ms 41.0056 Ops/s 42.2216 Ops/s $\color{#d91a1a}-2.88\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9044ms 0.7190ms 1.3908 KOps/s 1.4258 KOps/s $\color{#d91a1a}-2.45\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7372ms 0.6644ms 1.5052 KOps/s 1.5355 KOps/s $\color{#d91a1a}-1.98\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5327ms 1.4708ms 679.9118 Ops/s 688.0120 Ops/s $\color{#d91a1a}-1.18\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9467ms 0.6860ms 1.4577 KOps/s 1.4836 KOps/s $\color{#d91a1a}-1.75\%$
test_dqn_speed 3.9480ms 1.4767ms 677.1967 Ops/s 678.0002 Ops/s $\color{#d91a1a}-0.12\%$
test_ddpg_speed 2.9895ms 2.8040ms 356.6392 Ops/s 351.6545 Ops/s $\color{#35bf28}+1.42\%$
test_sac_speed 8.7597ms 8.2681ms 120.9467 Ops/s 121.7491 Ops/s $\color{#d91a1a}-0.66\%$
test_redq_speed 11.1047ms 10.2754ms 97.3196 Ops/s 98.2679 Ops/s $\color{#d91a1a}-0.97\%$
test_redq_deprec_speed 11.9702ms 11.5167ms 86.8303 Ops/s 90.5170 Ops/s $\color{#d91a1a}-4.07\%$
test_td3_speed 8.4841ms 8.2989ms 120.4976 Ops/s 121.0169 Ops/s $\color{#d91a1a}-0.43\%$
test_cql_speed 27.5583ms 25.1040ms 39.8343 Ops/s 39.8474 Ops/s $\color{#d91a1a}-0.03\%$
test_a2c_speed 5.4078ms 5.1724ms 193.3335 Ops/s 183.8698 Ops/s $\textbf{\color{#35bf28}+5.15\%}$
test_ppo_speed 6.3737ms 5.5040ms 181.6849 Ops/s 173.1536 Ops/s $\color{#35bf28}+4.93\%$
test_reinforce_speed 4.4458ms 4.1870ms 238.8335 Ops/s 223.6755 Ops/s $\textbf{\color{#35bf28}+6.78\%}$
test_iql_speed 19.1917ms 18.7918ms 53.2147 Ops/s 51.4141 Ops/s $\color{#35bf28}+3.50\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.1533ms 4.0114ms 249.2883 Ops/s 273.8070 Ops/s $\textbf{\color{#d91a1a}-8.95\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7031ms 0.5585ms 1.7904 KOps/s 1.8111 KOps/s $\color{#d91a1a}-1.14\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6629ms 0.5274ms 1.8960 KOps/s 1.9077 KOps/s $\color{#d91a1a}-0.61\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.2171ms 4.0189ms 248.8263 Ops/s 272.3983 Ops/s $\textbf{\color{#d91a1a}-8.65\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6841ms 0.5515ms 1.8131 KOps/s 1.8312 KOps/s $\color{#d91a1a}-0.99\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6456ms 0.5250ms 1.9047 KOps/s 1.9222 KOps/s $\color{#d91a1a}-0.91\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.2382ms 4.1199ms 242.7243 Ops/s 263.2610 Ops/s $\textbf{\color{#d91a1a}-7.80\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8281ms 0.6843ms 1.4614 KOps/s 1.3205 KOps/s $\textbf{\color{#35bf28}+10.67\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7939ms 0.6559ms 1.5247 KOps/s 1.5438 KOps/s $\color{#d91a1a}-1.24\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.0938ms 3.9971ms 250.1803 Ops/s 271.8461 Ops/s $\textbf{\color{#d91a1a}-7.97\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7056ms 0.5593ms 1.7879 KOps/s 1.8120 KOps/s $\color{#d91a1a}-1.32\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7224ms 0.5292ms 1.8895 KOps/s 1.9007 KOps/s $\color{#d91a1a}-0.59\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.1825ms 4.0045ms 249.7165 Ops/s 272.6360 Ops/s $\textbf{\color{#d91a1a}-8.41\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7067ms 0.5534ms 1.8069 KOps/s 1.8223 KOps/s $\color{#d91a1a}-0.84\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6764ms 0.5260ms 1.9011 KOps/s 1.9217 KOps/s $\color{#d91a1a}-1.07\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.2180ms 4.1101ms 243.3040 Ops/s 261.9497 Ops/s $\textbf{\color{#d91a1a}-7.12\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8332ms 0.6857ms 1.4585 KOps/s 1.4659 KOps/s $\color{#d91a1a}-0.51\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7888ms 0.6592ms 1.5169 KOps/s 1.5359 KOps/s $\color{#d91a1a}-1.23\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1193s 9.5713ms 104.4789 Ops/s 89.6946 Ops/s $\textbf{\color{#35bf28}+16.48\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1102s 18.4577ms 54.1779 Ops/s 63.1803 Ops/s $\textbf{\color{#d91a1a}-14.25\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.4376ms 3.2041ms 312.0955 Ops/s 335.9042 Ops/s $\textbf{\color{#d91a1a}-7.09\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1025s 9.2608ms 107.9821 Ops/s 90.4834 Ops/s $\textbf{\color{#35bf28}+19.34\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 19.4607ms 16.7662ms 59.6439 Ops/s 62.8944 Ops/s $\textbf{\color{#d91a1a}-5.17\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.9261ms 3.0813ms 324.5405 Ops/s 334.8568 Ops/s $\color{#d91a1a}-3.08\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1009s 11.4368ms 87.4373 Ops/s 87.6178 Ops/s $\color{#d91a1a}-0.21\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.5697ms 16.9469ms 59.0078 Ops/s 61.7764 Ops/s $\color{#d91a1a}-4.48\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.5834ms 3.3826ms 295.6278 Ops/s 306.9636 Ops/s $\color{#d91a1a}-3.69\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 63.3543ms 61.2116ms 16.3368 Ops/s 15.5170 Ops/s $\textbf{\color{#35bf28}+5.28\%}$
test_sync 48.3051ms 34.7896ms 28.7442 Ops/s 27.0627 Ops/s $\textbf{\color{#35bf28}+6.21\%}$
test_async 59.1742ms 29.6736ms 33.7000 Ops/s 33.9811 Ops/s $\color{#d91a1a}-0.83\%$
test_simple 0.4799s 0.4279s 2.3372 Ops/s 2.2973 Ops/s $\color{#35bf28}+1.74\%$
test_transformed 0.6260s 0.5757s 1.7371 Ops/s 1.7016 Ops/s $\color{#35bf28}+2.08\%$
test_serial 1.4297s 1.3844s 0.7223 Ops/s 0.6881 Ops/s $\color{#35bf28}+4.98\%$
test_parallel 1.4371s 1.3935s 0.7176 Ops/s 0.7001 Ops/s $\color{#35bf28}+2.50\%$
test_step_mdp_speed[True-True-True-True-True] 0.1386ms 21.4631μs 46.5916 KOps/s 47.2089 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[True-True-True-True-False] 36.8090μs 13.0660μs 76.5345 KOps/s 76.1649 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[True-True-True-False-True] 38.9730μs 12.4969μs 80.0196 KOps/s 81.1512 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[True-True-True-False-False] 69.4290μs 7.5108μs 133.1423 KOps/s 130.3387 KOps/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[True-True-False-True-True] 74.5790μs 22.7832μs 43.8920 KOps/s 43.7956 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-True-False-True-False] 39.1530μs 14.3987μs 69.4508 KOps/s 68.8769 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[True-True-False-False-True] 59.4570μs 13.7087μs 72.9463 KOps/s 73.1749 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[True-True-False-False-False] 45.0430μs 8.7413μs 114.3994 KOps/s 113.2469 KOps/s $\color{#35bf28}+1.02\%$
test_step_mdp_speed[True-False-True-True-True] 54.5710μs 24.1847μs 41.3484 KOps/s 41.3303 KOps/s $\color{#35bf28}+0.04\%$
test_step_mdp_speed[True-False-True-True-False] 61.4580μs 15.7252μs 63.5922 KOps/s 63.8394 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[True-False-True-False-True] 41.7380μs 13.5863μs 73.6034 KOps/s 73.6402 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[True-False-True-False-False] 38.7820μs 8.7638μs 114.1062 KOps/s 113.9280 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-False-False-True-True] 64.6410μs 25.5193μs 39.1861 KOps/s 39.8067 KOps/s $\color{#d91a1a}-1.56\%$
test_step_mdp_speed[True-False-False-True-False] 49.6720μs 16.7809μs 59.5914 KOps/s 59.6843 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[True-False-False-False-True] 45.1140μs 14.8917μs 67.1513 KOps/s 68.0194 KOps/s $\color{#d91a1a}-1.28\%$
test_step_mdp_speed[True-False-False-False-False] 40.4350μs 9.9298μs 100.7066 KOps/s 100.6208 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[False-True-True-True-True] 59.4410μs 24.1962μs 41.3288 KOps/s 41.5079 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[False-True-True-True-False] 46.3960μs 15.7687μs 63.4166 KOps/s 63.5637 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[False-True-True-False-True] 41.0860μs 15.9919μs 62.5317 KOps/s 63.2281 KOps/s $\color{#d91a1a}-1.10\%$
test_step_mdp_speed[False-True-True-False-False] 33.7940μs 9.9691μs 100.3103 KOps/s 99.8402 KOps/s $\color{#35bf28}+0.47\%$
test_step_mdp_speed[False-True-False-True-True] 52.5080μs 26.0204μs 38.4313 KOps/s 39.5469 KOps/s $\color{#d91a1a}-2.82\%$
test_step_mdp_speed[False-True-False-True-False] 40.2650μs 16.9421μs 59.0246 KOps/s 58.8679 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[False-True-False-False-True] 49.8330μs 17.1081μs 58.4520 KOps/s 58.5096 KOps/s $\color{#d91a1a}-0.10\%$
test_step_mdp_speed[False-True-False-False-False] 41.2160μs 11.2165μs 89.1543 KOps/s 89.4416 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[False-False-True-True-True] 62.9370μs 27.0568μs 36.9592 KOps/s 37.7389 KOps/s $\color{#d91a1a}-2.07\%$
test_step_mdp_speed[False-False-True-True-False] 48.1800μs 18.2318μs 54.8493 KOps/s 55.2618 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[False-False-True-False-True] 45.2540μs 17.4496μs 57.3079 KOps/s 58.9496 KOps/s $\color{#d91a1a}-2.78\%$
test_step_mdp_speed[False-False-True-False-False] 40.0440μs 11.3272μs 88.2832 KOps/s 89.4218 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[False-False-False-True-True] 81.5920μs 27.8666μs 35.8853 KOps/s 36.3034 KOps/s $\color{#d91a1a}-1.15\%$
test_step_mdp_speed[False-False-False-True-False] 48.0690μs 19.1308μs 52.2717 KOps/s 52.2741 KOps/s $-0.00\%$
test_step_mdp_speed[False-False-False-False-True] 58.0780μs 18.1555μs 55.0797 KOps/s 55.0887 KOps/s $\color{#d91a1a}-0.02\%$
test_step_mdp_speed[False-False-False-False-False] 34.1130μs 12.3005μs 81.2978 KOps/s 81.2491 KOps/s $\color{#35bf28}+0.06\%$
test_values[generalized_advantage_estimate-True-True] 9.5216ms 9.2159ms 108.5081 Ops/s 107.2770 Ops/s $\color{#35bf28}+1.15\%$
test_values[vec_generalized_advantage_estimate-True-True] 38.4292ms 35.4689ms 28.1937 Ops/s 28.3884 Ops/s $\color{#d91a1a}-0.69\%$
test_values[td0_return_estimate-False-False] 0.2352ms 0.1636ms 6.1142 KOps/s 5.8758 KOps/s $\color{#35bf28}+4.06\%$
test_values[td1_return_estimate-False-False] 26.0135ms 23.0530ms 43.3784 Ops/s 42.9385 Ops/s $\color{#35bf28}+1.02\%$
test_values[vec_td1_return_estimate-False-False] 36.3617ms 35.2410ms 28.3760 Ops/s 28.3032 Ops/s $\color{#35bf28}+0.26\%$
test_values[td_lambda_return_estimate-True-False] 36.5245ms 33.4863ms 29.8630 Ops/s 29.8459 Ops/s $\color{#35bf28}+0.06\%$
test_values[vec_td_lambda_return_estimate-True-False] 49.4350ms 35.8548ms 27.8903 Ops/s 28.3416 Ops/s $\color{#d91a1a}-1.59\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.0913ms 8.1594ms 122.5582 Ops/s 121.2595 Ops/s $\color{#35bf28}+1.07\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.1345ms 1.8441ms 542.2820 Ops/s 511.9188 Ops/s $\textbf{\color{#35bf28}+5.93\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4115ms 0.3475ms 2.8780 KOps/s 2.8779 KOps/s $+0.00\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 42.7929ms 40.4807ms 24.7032 Ops/s 22.1649 Ops/s $\textbf{\color{#35bf28}+11.45\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7399ms 3.0279ms 330.2614 Ops/s 330.7563 Ops/s $\color{#d91a1a}-0.15\%$
test_dqn_speed 64.7001ms 1.4700ms 680.2583 Ops/s 716.5407 Ops/s $\textbf{\color{#d91a1a}-5.06\%}$
test_ddpg_speed 3.4958ms 2.7631ms 361.9171 Ops/s 354.9730 Ops/s $\color{#35bf28}+1.96\%$
test_sac_speed 8.6548ms 8.2105ms 121.7946 Ops/s 119.5996 Ops/s $\color{#35bf28}+1.84\%$
test_redq_speed 18.7706ms 13.1824ms 75.8589 Ops/s 76.2723 Ops/s $\color{#d91a1a}-0.54\%$
test_redq_deprec_speed 13.5993ms 12.8905ms 77.5765 Ops/s 76.5614 Ops/s $\color{#35bf28}+1.33\%$
test_td3_speed 8.4701ms 8.2316ms 121.4837 Ops/s 119.8435 Ops/s $\color{#35bf28}+1.37\%$
test_cql_speed 36.7241ms 36.0856ms 27.7119 Ops/s 27.6131 Ops/s $\color{#35bf28}+0.36\%$
test_a2c_speed 8.7337ms 7.3066ms 136.8631 Ops/s 135.4732 Ops/s $\color{#35bf28}+1.03\%$
test_ppo_speed 8.1029ms 7.6309ms 131.0469 Ops/s 130.3594 Ops/s $\color{#35bf28}+0.53\%$
test_reinforce_speed 7.6581ms 6.5439ms 152.8147 Ops/s 151.9884 Ops/s $\color{#35bf28}+0.54\%$
test_iql_speed 33.9053ms 32.3378ms 30.9236 Ops/s 30.8257 Ops/s $\color{#35bf28}+0.32\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.0308ms 2.7389ms 365.1104 Ops/s 370.2165 Ops/s $\color{#d91a1a}-1.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7361ms 0.5044ms 1.9825 KOps/s 1.9512 KOps/s $\color{#35bf28}+1.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6332ms 0.4754ms 2.1036 KOps/s 2.0735 KOps/s $\color{#35bf28}+1.45\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.0114ms 2.7615ms 362.1264 Ops/s 362.7508 Ops/s $\color{#d91a1a}-0.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8808ms 0.4989ms 2.0045 KOps/s 1.9877 KOps/s $\color{#35bf28}+0.85\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8010ms 0.4756ms 2.1026 KOps/s 2.0901 KOps/s $\color{#35bf28}+0.60\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1400ms 2.8517ms 350.6631 Ops/s 349.2124 Ops/s $\color{#35bf28}+0.42\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8853ms 0.6186ms 1.6165 KOps/s 1.5957 KOps/s $\color{#35bf28}+1.30\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9156ms 0.5919ms 1.6895 KOps/s 1.6758 KOps/s $\color{#35bf28}+0.82\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9032ms 2.7153ms 368.2884 Ops/s 367.6219 Ops/s $\color{#35bf28}+0.18\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8592ms 0.5034ms 1.9865 KOps/s 1.9538 KOps/s $\color{#35bf28}+1.68\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8371ms 0.4824ms 2.0730 KOps/s 2.0749 KOps/s $\color{#d91a1a}-0.09\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.2598ms 2.7762ms 360.2106 Ops/s 359.4893 Ops/s $\color{#35bf28}+0.20\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6107ms 0.4995ms 2.0019 KOps/s 1.9863 KOps/s $\color{#35bf28}+0.78\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7422ms 0.4802ms 2.0823 KOps/s 2.0850 KOps/s $\color{#d91a1a}-0.13\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.1523ms 2.8419ms 351.8715 Ops/s 347.1359 Ops/s $\color{#35bf28}+1.36\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7498ms 0.6166ms 1.6219 KOps/s 1.6014 KOps/s $\color{#35bf28}+1.28\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8908ms 0.5944ms 1.6824 KOps/s 1.6637 KOps/s $\color{#35bf28}+1.12\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1081s 7.8037ms 128.1449 Ops/s 130.7576 Ops/s $\color{#d91a1a}-2.00\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.7651ms 13.1749ms 75.9022 Ops/s 77.3657 Ops/s $\color{#d91a1a}-1.89\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.3939ms 2.5211ms 396.6581 Ops/s 397.6669 Ops/s $\color{#d91a1a}-0.25\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 91.3963ms 9.1113ms 109.7544 Ops/s 111.5088 Ops/s $\color{#d91a1a}-1.57\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.6174ms 13.1866ms 75.8348 Ops/s 77.3677 Ops/s $\color{#d91a1a}-1.98\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.9812ms 2.5482ms 392.4391 Ops/s 392.2132 Ops/s $\color{#35bf28}+0.06\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 92.4772ms 9.5245ms 104.9922 Ops/s 106.2689 Ops/s $\color{#d91a1a}-1.20\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.1016ms 13.4195ms 74.5185 Ops/s 75.9755 Ops/s $\color{#d91a1a}-1.92\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.2554ms 3.4383ms 290.8424 Ops/s 343.0390 Ops/s $\textbf{\color{#d91a1a}-15.22\%}$

@vmoens vmoens added bug Something isn't working CI Has to do with CI setup (e.g. wheels & builds, tests...) Suitable for minor Suitable to be integrated in minor release (no new feature) labels Feb 20, 2024
@vmoens vmoens merged commit 13bef42 into main Feb 20, 2024
5 of 13 checks passed
@vmoens vmoens deleted the fix-habitat2 branch February 20, 2024 22:36
vmoens added a commit that referenced this pull request Feb 28, 2024
@vmoens
[BugFix] Fix habitat (#1941)
1187fc5
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Suitable for minor Suitable to be integrated in minor release (no new feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot