Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Remove reset on last step of a rollout #1936

Merged
merged 24 commits into from
Feb 21, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update torchrl/envs/common.py
  • Loading branch information
vmoens committed Feb 21, 2024
commit 621afd5477703e7bde24add2d60bf580732dfec7
6 changes: 0 additions & 6 deletions torchrl/envs/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -2389,12 +2389,6 @@ def rollout(
... )
... input_td = step_mdp(
... rollout_td[..., -1],
... keep_other=True,
... exclude_action=False,
... exclude_reward=True,
... reward_keys=env.reward_keys,
... action_keys=env.action_keys,
... done_keys=env.done_keys,
... )

"""
Expand Down
Loading