Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Deprecate direct usage of memmap tensors #1699

Merged
merged 12 commits into from
Nov 15, 2023
Merged

[Refactor] Deprecate direct usage of memmap tensors #1699

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eeefb18
empty
vmoens Nov 8, 2023
3832c37
amend
vmoens Nov 8, 2023
dd525cf
amend
vmoens Nov 14, 2023
24a4ed3
amend
vmoens Nov 14, 2023
e362a75
Merge branch 'main' into deprecate_direct_memmap
vmoens Nov 14, 2023
0f9dec3
fix rb_dist tests
vmoens Nov 14, 2023
382e15e
Update run_all.sh
vmoens Nov 14, 2023
0df1bed
lint
vmoens Nov 14, 2023
8e03df4
empty
vmoens Nov 15, 2023
4d1c67c
amend
vmoens Nov 15, 2023
07cbbfe
amend
vmoens Nov 15, 2023
6595212
lint
vmoens Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@vmoens
vmoens committed Nov 14, 2023
commit 0df1bede51d9525389cf49aa1af3fbc991339c42
1 change: 0 additions & 1 deletion test/test_rb_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import os

import sys
import tempfile
import time

import pytest
Expand Down
2 changes: 1 addition & 1 deletion torchrl/objectives/value/functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

import torch

from tensordict import MemmapTensor, MemoryMappedTensor
from tensordict import MemmapTensor

__all__ = [
"generalized_advantage_estimate",
Expand Down
Loading