Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Threaded collection and parallel envs #1559

Merged
merged 10 commits into from
Sep 22, 2023
Merged

[Feature] Threaded collection and parallel envs #1559

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4e8acc0
init
vmoens Sep 21, 2023
c8579f9
init
vmoens Sep 21, 2023
d95989c
Merge branch 'fix_dreamer_tests' into threads_mp
vmoens Sep 21, 2023
acf89e6
amend
vmoens Sep 21, 2023
16fba2e
amend
vmoens Sep 21, 2023
5e38d70
Update torchrl/collectors/collectors.py
vmoens Sep 21, 2023
e1eba40
Merge remote-tracking branch 'origin/main' into threads_mp
vmoens Sep 21, 2023
9f58a8d
lint
vmoens Sep 21, 2023
1c4f35f
amend
vmoens Sep 21, 2023
9021e19
tests
vmoens Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update torchrl/collectors/collectors.py 
Co-authored-by: Matteo Bettini <[email protected]>
  • Loading branch information
@vmoens @matteobettini
vmoens and matteobettini authored Sep 21, 2023
commit 5e38d703e8e9a1ea080e4a0f0ebcc525a93856e5
1 change: 0 additions & 1 deletion torchrl/collectors/collectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,6 @@ class _MultiDataCollector(DataCollectorBase):
that will be allowed to finished collecting their rollout before the rest are forced to end early.
num_threads (int, optional): number of threads for this process.
Defaults to the number of workers.
This parameter has no effect for the :class:`~SerialEnv` class.
num_sub_threads (int, optional): number of threads of the subprocesses.
Should be equal to one plus the number of processes launched within
each subprocess (or one if a single process is launched).
Expand Down