Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Features] Conv3dNet and PermuteTransform #1398

Merged
merged 15 commits into from
Sep 16, 2023
Merged

[Features] Conv3dNet and PermuteTransform #1398

merged 15 commits into from
Sep 16, 2023

Conversation

xmaples
Copy link
Contributor

@xmaples xmaples commented Jul 19, 2023

Description

Add features of Conv3dNet, similar to ConvNet but with 3d convolution layers, and PermuteTransform being a utility tool to transform tensors to ones with shape required by conv3d.

Types of changes

  • New feature (non-breaking change which adds core functionality)
  • Documentation (update in the documentation)
  • Example (in doc)
  • Tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2023
vmoens
vmoens reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Really useful thanks a mil!
A few suggestions

torchrl/modules/models/__init__.py Show resolved Hide resolved
torchrl/modules/models/models.py Outdated Show resolved Hide resolved
torchrl/modules/models/models.py Outdated Show resolved Hide resolved
torchrl/modules/models/models.py Outdated Show resolved Hide resolved
torchrl/modules/models/models.py Outdated Show resolved Hide resolved
torchrl/envs/transforms/transforms.py Outdated Show resolved Hide resolved
test/test_transforms.py Outdated Show resolved Hide resolved
test/test_modules.py Outdated Show resolved Hide resolved
test/test_modules.py Outdated Show resolved Hide resolved
xmaples and others added 6 commits July 20, 2023 10:26
@xmaples @vmoens
error msg
5b45d10 
Co-authored-by: Vincent Moens <[email protected]>
@xmaples @vmoens
doc
4ef3753 
Co-authored-by: Vincent Moens <[email protected]>
@xmaples @vmoens
by depth
290d8b3 
Co-authored-by: Vincent Moens <[email protected]>
@xmaples @vmoens
doc
1d2723c 
Co-authored-by: Vincent Moens <[email protected]>
@xmaples @vmoens
dims check
8ddbc09 
Co-authored-by: Vincent Moens <[email protected]>
@xmaples
more tests
6e00f6c
@vmoens vmoens added the enhancement New feature or request label Sep 7, 2023
@vmoens
Merge branch 'main' into HEAD
519975b 
# Conflicts:
#	test/test_modules.py
#	test/test_transforms.py
@vmoens
lint
394690e
@vmoens
Copy link
Contributor

vmoens commented Sep 8, 2023

@xmaples I made a PR against this branch. I think you can safely merge it and start from there. There should be very little to do once the patch is merged!

@vmoens vmoens merged commit ecf6477 into pytorch:main Sep 16, 2023
53 of 59 checks passed
albertbou92 pushed a commit to PyTorchRL/rl that referenced this pull request Sep 18, 2023
@xmaples @vmoens @albertbou92
[Features] Conv3dNet and PermuteTransform (pytorch#1398)
4d4a447 
Co-authored-by: vmoens <[email protected]>
vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@xmaples @vmoens
[Features] Conv3dNet and PermuteTransform (pytorch#1398)
3430168 
Co-authored-by: vmoens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xmaples @vmoens @facebook-github-bot