Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Change default of skip_existing to None #1082

Merged
merged 1 commit into from
Apr 24, 2023
Merged

[BugFix] Change default of skip_existing to None #1082

merged 1 commit into from
Apr 24, 2023

Conversation

tcbegley
Copy link
Contributor

@tcbegley tcbegley commented Apr 24, 2023 •
edited
Loading

This is the behaviour stated in the docstring, and the current default value of False makes it impossible to override skip_existing with the set_skip_existing context manager.

@tcbegley
Change default of skip_existing to None
834d04c 
This is the behaviour stated in the docstring, and the current default
value of False makes it impossible to override `skip_existing` with the
`set_skip_existing` context manager.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2023
@vmoens vmoens added the bug Something isn't working label Apr 24, 2023
@vmoens vmoens changed the title Change default of skip_existing to None [BugFix] Change default of skip_existing to None Apr 24, 2023
vmoens
vmoens approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit df233fb into pytorch:main Apr 24, 2023
@vmoens vmoens deleted the advantages-skip-existing-default branch April 24, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tcbegley @vmoens @facebook-github-bot