Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add length and padding keyworks to DistributedSampler #28841

Closed
wants to merge 5 commits into from
Closed

Add length and padding keyworks to DistributedSampler #28841

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44b631e
Add length and padding keyworks to DistributedSampler
Oct 25, 2019
e2ea293
Fix sampler __len__ method
Oct 29, 2019
77c2046
Address comments
Oct 29, 2019
a1ce4d8
Improve error msg
Oct 29, 2019
2a96465
Fix assert for padding scenarios
Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix sampler __len__ method
  • Loading branch information
Thiago Crepaldi committed Oct 29, 2019
commit e2ea2938cee4159e9ccda5e255df1da5590b8451
4 changes: 3 additions & 1 deletion torch/utils/data/distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ def __iter__(self):
return iter(indices)

def __len__(self):
return self.num_samples
if self.padding:
return self.num_samples
return self._dataset_length
thiagocrepaldi marked this conversation as resolved.
Show resolved Hide resolved

def set_rank(self, rank):
thiagocrepaldi marked this conversation as resolved.
Show resolved Hide resolved
assert rank >= 0, 'rank must be >= 0'
Expand Down