Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pin_memory_thread not exiting quickly #23646

Closed
wants to merge 1 commit into from
Closed

Conversation

ssnl
Copy link
Collaborator

@ssnl ssnl commented Aug 1, 2019

fixes #23642

@pytorchbot pytorchbot added the module: dataloader Related to torch.utils.data.DataLoader and Sampler label Aug 1, 2019
@ssnl ssnl mentioned this pull request Aug 1, 2019
@ssnl ssnl requested a review from apaszke August 1, 2019 06:05
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel
Copy link
Collaborator

ngimel commented Aug 1, 2019

Can we have a test timinig worker shutdown (similar to example in #23642), or do you think it will be too flaky?

@ssnl
Copy link
Collaborator Author

ssnl commented Aug 1, 2019 via email

@facebook-github-bot
Copy link
Contributor

@soumith merged this pull request in 0539462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: dataloader Related to torch.utils.data.DataLoader and Sampler open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance Regression of Dataloader
7 participants