-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[inductor] Use multiple outputs for flex-attention #129344
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2024
lezcano
approved these changes
Jul 1, 2024
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jul 11, 2024
This fixes the DCE issue for attention output ghstack-source-id: ae12dc6ed5a49a90e98a09b476b8c8cefa109036 Pull Request resolved: pytorch#129344
|
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jul 16, 2024
This fixes the DCE issue for attention output ghstack-source-id: 63c029e202b76628eb0e5a95197cd26dbd3a48f7 Pull Request resolved: pytorch#129344
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jul 19, 2024
Resubmit of pytorch#129344 This fixes the DCE issue for attention output ghstack-source-id: 82d576fe8e3260ea1f6d4f985d1280db80e9975d Pull Request resolved: pytorch#130833
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 20, 2024
Resubmit of #129344 This fixes the DCE issue for attention output Pull Request resolved: #130833 Approved by: https://github.com/lezcano ghstack dependencies: #130831, #130832
DiweiSun
pushed a commit
to DiweiSun/pytorch
that referenced
this pull request
Jul 22, 2024
Resubmit of pytorch#129344 This fixes the DCE issue for attention output Pull Request resolved: pytorch#130833 Approved by: https://github.com/lezcano ghstack dependencies: pytorch#130831, pytorch#130832
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jul 22, 2024
Resubmit of pytorch#129344 This fixes the DCE issue for attention output ghstack-source-id: af6e765260e77857e5394b97595f60bf6d6cba84 Pull Request resolved: pytorch#130833
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jul 23, 2024
Resubmit of pytorch#129344 This fixes the DCE issue for attention output ghstack-source-id: 2d8d21c599cf87c229bc17146c8e4fd39e0dcf7d Pull Request resolved: pytorch#130833
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Resubmit of #129344 This fixes the DCE issue for attention output Pull Request resolved: #130833 Approved by: https://github.com/lezcano ghstack dependencies: #130832
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
Resubmit of pytorch#129344 This fixes the DCE issue for attention output Pull Request resolved: pytorch#130833 Approved by: https://github.com/lezcano ghstack dependencies: pytorch#130831, pytorch#130832
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
Resubmit of pytorch#129344 This fixes the DCE issue for attention output Pull Request resolved: pytorch#130833 Approved by: https://github.com/lezcano ghstack dependencies: pytorch#130832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This fixes the DCE issue for attention output
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang