Skip signals from older runs of the same workflows #129291
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this bug in trymerge when debugging #129013 in which Dr.CI reported no relevant failures while mergebot complained about some unrelated ROCm failures #129013 (comment).
It turns out that mergebot took into account stale signals from older runs of the same workflow here. For example,
Notice that both runs came from the same push to commit be69191 with ciflow/rocm/129013. So, we just need to check the signals from the newer run.
Note that Dr.CI handles this part correctly using the logic in https://github.com/pytorch/test-infra/blob/main/torchci/pages/api/drci/drci.ts#L1079-L1088. So, the fix in this PR is to bring the same logic to trymerge.
Testing
pytest -v test_trymerge.py