Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Add JSON logging #129196

Closed
wants to merge 4 commits into from
Closed

[RFC] Add JSON logging #129196

wants to merge 4 commits into from

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Jun 21, 2024 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Summary:
Add JSON header files.
TODO:
return NCCL dump as JSON.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k

@c-p-i-o
Update
0fa3ff4 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129196

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 3 Cancelled Jobs, 17 Unrelated Failures

As of commit 7e8fb74 with merge base 1865fe2 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Jun 21, 2024
@c-p-i-o c-p-i-o marked this pull request as draft June 21, 2024 01:15
@c-p-i-o
Update
b1c4b8f 
[ghstack-poisoned]
c-p-i-o added a commit that referenced this pull request Jun 21, 2024
@c-p-i-o
[RFC] Add JSON logging
28a4a69 
Summary:
Add JSON header files.
TODO:
return NCCL dump as JSON.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ef6d69f805b21c59512d6a0643dd0400a835eded
Pull Request resolved: #129196
@c-p-i-o
Update
62594af 
[ghstack-poisoned]
@c-p-i-o
Update
7e8fb74 
[ghstack-poisoned]
c-p-i-o added a commit that referenced this pull request Jun 25, 2024
@c-p-i-o
[RFC] Add JSON flight recorder data
491e8d4 
Summary:
Send back flight recorder data back as JSON.

Test Plan:
unit tests

ghstack-source-id: c973f5f73813d7842c74e124ba48ac8a463f22ed
Pull Request resolved: #129196
@c-p-i-o c-p-i-o closed this Jun 25, 2024
@github-actions github-actions bot deleted the gh/c-p-i-o/19/head branch July 26, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@c-p-i-o